Zoisite - Jessica and Whitney - Waves 1 & 2#19
Open
WhitShake wants to merge 19 commits intoAda-C19:mainfrom
Open
Zoisite - Jessica and Whitney - Waves 1 & 2#19WhitShake wants to merge 19 commits intoAda-C19:mainfrom
WhitShake wants to merge 19 commits intoAda-C19:mainfrom
Conversation
apradoada
reviewed
Apr 28, 2023
apradoada
left a comment
apradoada
left a comment
There was a problem hiding this comment.
Overall this looks really great! Well done, y'all!
|
|
||
| from .routes import planets_bp | ||
| app.register_blueprint(planets_bp) | ||
|
|
| Planet(6, "Saturn", "Known for its prominent rings made of ice and dust", 568), | ||
| Planet(7, "Uranus", "Blue-green planet with a tilted axis of rotation", 86.8), | ||
| Planet(8, "Neptune", "Blue planet with a windy atmosphere and many storms", 102), | ||
| ] |
There was a problem hiding this comment.
Great job setting up your planet class and planet list!
| for planet in planet_list: | ||
| planets_response.append(planet.to_dict()) | ||
|
|
||
| return jsonify(planets_response), 200 |
There was a problem hiding this comment.
This looks good, but I wonder if it would be a good candidate for a list comprehension... 🤔
| if planet.id == id: | ||
| return planet | ||
|
|
||
| abort(make_response({"message": f"Planet {id} is not found!"}, 404)) No newline at end of file |
There was a problem hiding this comment.
The rest of this looks good too! Well done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.