Angelica Yee and Genesis Solar System Project Kunzite #27
Open
genesisquinn wants to merge 21 commits intoAda-C19:mainfrom
Open
Angelica Yee and Genesis Solar System Project Kunzite #27genesisquinn wants to merge 21 commits intoAda-C19:mainfrom
genesisquinn wants to merge 21 commits intoAda-C19:mainfrom
Conversation
Wave 3 start
genesisquinn
changed the title
genesisquinn
changed the title
genesisquinn
changed the title
spitsfire
reviewed
May 11, 2023
spitsfire
left a comment
spitsfire
left a comment
There was a problem hiding this comment.
Looks good! Keep an eye on your responses, though. You want to keep them as consistent as possible and include a status code
Comment on lines
+18
to
+19
| #app.config['SQLALCHEMY_DATABASE_URI'] = os.environ.get( | ||
| # "SQLALCHEMY_DATABASE_URI") |
There was a problem hiding this comment.
Suggested change
| #app.config['SQLALCHEMY_DATABASE_URI'] = os.environ.get( | |
| # "SQLALCHEMY_DATABASE_URI") |
Let's remove commented code if we aren't using it
Comment on lines
+7
to
+8
| planet= db.relationship("Planet", back_populates="moons") | ||
| planet_id= db.Column(db.Integer, db.ForeignKey('planet.id')) |
There was a problem hiding this comment.
Suggested change
| planet= db.relationship("Planet", back_populates="moons") | |
| planet_id= db.Column(db.Integer, db.ForeignKey('planet.id')) | |
| planet = db.relationship("Planet", back_populates="moons") | |
| planet_id = db.Column(db.Integer, db.ForeignKey('planet.id')) |
| db.session.delete(planet) | ||
| db.session.commit() | ||
|
|
||
| return make_response(f"Planet#{planet.id} successfully deleted") |
| planet=validate_model(Planet, planet_id) | ||
| request_body=request.get_json() | ||
|
|
||
| if request_body.get("name") is None or request_body.get("description") is None or request_body.get("moons") is None: |
There was a problem hiding this comment.
Suggested change
| if request_body.get("name") is None or request_body.get("description") is None or request_body.get("moons") is None: | |
| if request_body.get("name") is None or \ | |
| request_body.get("description") is None or \ | |
| request_body.get("moons") is None: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.