Luqi (Phoenix) & Sunitha(Sphinx) Solar System Wave 01 to Wave 06#5
Luqi (Phoenix) & Sunitha(Sphinx) Solar System Wave 01 to Wave 06#5nelasunitha wants to merge 10 commits intoAda-C22:mainfrom
Conversation
yangashley
left a comment
yangashley
left a comment
There was a problem hiding this comment.
Nice work here! Your project directory is correctly organized and your model/routes look good.
There was a problem hiding this comment.
This file should be empty. This logic only needs to be written in app/__init__.py
nelasunitha
changed the title
|
Please review our code from wave 01 through wave 06. |
yangashley
left a comment
yangashley
left a comment
There was a problem hiding this comment.
Nice work on part 2 of solar system!
| name_param = request.args.get("name") | ||
| if name_param: | ||
| query = query.where(Planet.name.ilike(f"%{name_param}%")).order_by(Planet.id) | ||
|
|
There was a problem hiding this comment.
Remove extra blank line. When we use blank line to break up long chunks of code, we only need one blank line.
There was a problem hiding this comment.
Is this file just for practice? I'm not clear on what it's testing and it's not inside your test directory.
There was a problem hiding this comment.
Yes, We have written this to test for practice.
3 participants
Please review our code. Thanks!