Ania and Suze #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Seed data now loads, and includes logic to take care of asynchronous seeding for customers and movies.
…r each. working at root.
…als routes. Opened a rentals_controller.js.
… as release_date and inventory.
…ts and in package.json. server wokin again.
Please enter the commit message for #your changes. Lines starting
…ls currently out for specific.
…ed logic in model to charge for the movie.
…nventory in the database.
…ot working yet. urrently stuck on error: throw new Error('Can\'t set headers after they are sent.');
| var CustomersController = { | ||
|
|
||
| getCustomers: function(req, res, next) { | ||
| // giving a callback function to handle error or render view |
There was a problem hiding this comment.
Remember to remove any unnecessary comments before submitting your final PR. They are super helpful during development, though, huh? :)
|
Hey @SuzHarrison and @aniagonzalez, great job! 🎉⭐️👍 I know close to nothing about Express so it was difficult to do a CR in that respect. Looks like you got a pretty good handle on it though. Love your commit messages (very detailed) and how often you committed. Two take aways I would suggest: remove any unnecessary comments from code and be as descriptive as you can in naming variables, methods, etc. |
| @@ -0,0 +1,10 @@ | |||
| SELECT | |||
There was a problem hiding this comment.
this query is the same as the previous one. I wonder if they're both necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did our best to get through the main requirements, but did not get to testing every end point and the requirements added Monday. Some testing passing for models and we were able to set up a testing db.