Tweak example in assigments RFC #181
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the example code in the assignments RFC. The new code is more efficient since it removes a free+malloc pair per assignment, and the new behavior would be much more difficult to achieve with Standard Ada controlled types.
QuentinOchem
reviewed
Dec 1, 2025
| begin | ||
| Free (To.A); | ||
| To.A := new Integer'(Self.A.all); | ||
| To.A.all := Self.A.all; |
Contributor
There was a problem hiding this comment.
The intent here is to demonstrate cleanup of the destination as well as deep copy. Perhaps using a string access instead of an integer will be better, let me see how to rewrite the example for that.
Contributor
Author
|
I put a rationale for the change in the commit message, but I just realized that GitHub's UI makes it easy to miss. |
Contributor
Interesting - so indeed we're trying to show two different things. Would you mind if I put your example in the rationale bit, so that we keep the description of cleanup in the general case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.