Skip to content

Configures cookie settings for OAuth. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdaInTheLab merged 1 commit into from
Jan 6, 2026
Merged

Configures cookie settings for OAuth. #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 7 additions & 19 deletions src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,16 +176,16 @@ export function createApp() {
cookie: {
httpOnly: true,

// ✅ must be true when sameSite is "none"
secure: isProd,
// ✅ must be true when sameSite is "none"
secure: isProd,

sameSite: cookieSameSite,
sameSite: "none",

// ✅ allow cookie across root + api subdomain (prod only)
domain: isProd ? ".thehumanpatternlab.com" : undefined,
// ✅ allow cookie across root + api subdomain (prod only)
domain: isProd ? ".thehumanpatternlab.com" : undefined,

// Optional: makes sessions survive restarts for a bit
// maxAge: 1000 * 60 * 60 * 24 * 7,
// Optional: makes sessions survive restarts for a bit
// maxAge: 1000 * 60 * 60 * 24 * 7,
},
})
);
Expand Down Expand Up @@ -217,18 +217,6 @@ export function createApp() {
});
});

//TODO: THIS IS TEMP
app.get("/auth/cookie-test", (req, res) => {
(req.session as any).cookie_test = Date.now();

res.json({
ok: true,
wrote: true,
hasCookieHeader: Boolean(req.headers.cookie),
sessionID: req.sessionID,
});
});

/* ===========================================================
12) ROUTES (LAST)
-----------------------------------------------------------
Expand Down