Feature: mark Send and Sync on Toolbox trait#32
Merged
AdamStrojek merged 1 commit intoAdamStrojek:masterfrom Sep 10, 2025
Merged
Feature: mark Send and Sync on Toolbox trait#32AdamStrojek merged 1 commit intoAdamStrojek:masterfrom
AdamStrojek merged 1 commit intoAdamStrojek:masterfrom
Conversation
Owner
|
Thank you for your contribution. Yes, you are right, PR #24 is waiting to address the concerns I reported. I'm currently not using my library in a multithreaded environment, but reviewing your change, it should be helpful for other developers. Before merging this PR, please review the problems reported by CI. |
fvanzee
force-pushed
the
feature/send-sync-on-toolbox
branch
from
fdc77a8 to
dd9c24c
Compare
Owner
|
Please reformat your code using |
fvanzee
force-pushed
the
feature/send-sync-on-toolbox
branch
from
dd9c24c to
f44cf75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for building this crate. It's coming is use for some hobby project I'm working on.
This small change marks the Toolbox trait safe for sending and sharing between threads.
I ran into this when trying to use an Agent in an axum API, which would not compile due to these markers missing.
Noticed that this was also already included in PR #24, but I got the feeling there's too many open remarks on there for it to get merged.