feat: Sane forge prices, data-driven shop, price mods

[EttyKitty]

Purpose of changes

• Revive feat: Huge shop/forge price overhaul/refactor #425.
• Make the shop code not as dogshit.
• Make item prices more fluid.
• Deprecate diplo screen item trading.

Describe the solution

• Changes all forge prices to be a x10 of the buying price, for consistency and ease of balance, instead of arbitrary numbers.
• Removes the need to buy things from factions through diplomacy, by allowing to buy all of them directly through the shop.
• Adds a dynamic modifier that is based on your relationship with the faction that is selling an item (can be a list of factions, then faction with the best attitude is picked).
  • Said relationship modifier, modifies prices for all items in the shop by using Mechanicus relationship by default, if no other faction sells that item.
  • Refactors various parts of the existing price formula code (rogue trader discounts, forge master stat dependent price mods).
• Refactors a lot of code lines for readability.

Describe alternatives you've considered

• Perhaps value property can be attached to weapons in the main struct, for the ease of balance.

Testing done

None

Related links

• feat: Huge shop/forge price overhaul/refactor #425
• Project: https://discord.com/channels/714022226810372107/1284618371668906094

Custom player notes entry

Use the PR title.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Blogaugis]

I find MK5 armor - supposedly the weakest of armors (besides the MK1 and perhaps MK2, which don't exist in the game) - to cost 225% of the standard issue (MK7), really questionable.

You sure this should be a thing?
Also requirement to have that "ceramite_casting_chambers" tech is a bit odd, but at least I can see the logic of it being requirement for all the power armors.