fix(onsen): handle numeric 'updated' field from API#4
Merged
Conversation
The Onsen.ag API has started returning numeric values (e.g., 23111) for the
'updated' field in the programs list, which previously only contained
date strings (e.g., "10/22") or null. This caused a JSON unmarshaling
error because the field was hardcoded as *string.
This change:
- Updates nuxt.Program.Updated to interface{} to accept both strings and
numbers.
- Safely handles type assertions in onsen.Radio.JstUpdatedAt().
- Updates associated tests to reflect the change from pointer to interface.
Analysis of current API data suggests that even when 'updated' is numeric
and unusable for date parsing, the application can still successfully
derive the correct JST update time from episode streaming URLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Onsen.ag API has started returning numeric values (e.g., 23111) for the 'updated' field in the programs list, which previously only contained date strings (e.g., "10/22") or null. This caused a JSON unmarshaling error because the field was hardcoded as *string.
This change:
Analysis of current API data suggests that even when 'updated' is numeric and unusable for date parsing, the application can still successfully derive the correct JST update time from episode streaming URLs.