[Webhooks] Code generation: update services and models #819
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the generated code for Adyen's webhook services and models. These changes are a direct result of recent modifications to the OpenAPI specification files. The primary purpose is to keep the client libraries synchronized with the latest API definitions, ensuring compatibility and access to new features or corrected behaviors. The updates include minor code formatting improvements in serializer classes and PHPDoc comment adjustments in model definitions.
Highlights
- Automated Code Generation Update: This pull request contains automatically generated code updates for various webhook services and models, reflecting recent changes in the underlying OpenAPI specifications.
- Code Formatting Standardization: Several
ObjectSerializer.phpfiles across different webhook modules have been updated to standardize code formatting, specifically adjusting whitespace inforeachloops and simplifyingifstatement syntax. - PHPDoc Comment Refinements: Minor adjustments were made to PHPDoc comments in
CapabilitySettings.phpto ensure consistent formatting of@paramtags.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request appears to be an automated code generation task to update services and models based on new OpenAPI specifications. While the core changes are from a generator, several stylistic issues have been introduced across multiple files. These include violations of the PSR-12 coding standard, such as incorrect spacing in foreach loops and the use of single-line if statements without braces, which can harm readability and maintainability. Additionally, some PHPDoc comments now contain unnecessary trailing whitespace. My review focuses on these stylistic regressions to ensure the codebase remains clean and consistent.
| @@ -82,7 +82,7 @@ public static function sanitizeForSerialization($data, $type = null, $format = n | |||
| } | |||
| } | |||
| } else { | |||
| foreach ($data as $property => $value) { | |||
| foreach($data as $property => $value) { | |||
There was a problem hiding this comment.
This foreach statement is missing a space after the keyword. According to the PSR-12 coding standard, there must be one space after control structure keywords like foreach to ensure code consistency and readability. The previous version of the code was compliant with this rule.
foreach ($data as $property => $value) {| if (!is_string($timestamp)) { | ||
| return $timestamp; | ||
| } | ||
| if (!is_string($timestamp)) return $timestamp; |
There was a problem hiding this comment.
This change converts a multi-line if statement with braces to a single-line statement without them. The PSR-12 standard recommends always using braces for if statements to improve code clarity and prevent potential bugs when adding more lines to the block. The original code was more compliant with this standard.
if (!is_string($timestamp)) {
return $timestamp;
}| @@ -82,7 +82,7 @@ public static function sanitizeForSerialization($data, $type = null, $format = n | |||
| } | |||
| } | |||
| } else { | |||
| foreach ($data as $property => $value) { | |||
| foreach($data as $property => $value) { | |||
There was a problem hiding this comment.
This foreach statement is missing a space after the keyword. According to the PSR-12 coding standard, there must be one space after control structure keywords like foreach to ensure code consistency and readability. The previous version of the code was compliant with this rule.
foreach ($data as $property => $value) {| if (!is_string($timestamp)) { | ||
| return $timestamp; | ||
| } | ||
| if (!is_string($timestamp)) return $timestamp; |
There was a problem hiding this comment.
This change converts a multi-line if statement with braces to a single-line statement without them. The PSR-12 standard recommends always using braces for if statements to improve code clarity and prevent potential bugs when adding more lines to the block. The original code was more compliant with this standard.
if (!is_string($timestamp)) {
return $timestamp;
}| @@ -355,7 +355,7 @@ public function getAmountPerIndustry() | |||
| /** | |||
| * Sets amountPerIndustry | |||
| * | |||
| * @param array<string,\Adyen\Model\ConfigurationWebhooks\Amount>|null $amountPerIndustry | |||
| * @param array<string,\Adyen\Model\ConfigurationWebhooks\Amount>|null $amountPerIndustry | |||
There was a problem hiding this comment.
This line has a trailing whitespace. While it doesn't affect functionality, it's best practice to remove it to maintain code cleanliness.
* @param array<string,\Adyen\Model\ConfigurationWebhooks\Amount>|null $amountPerIndustry| if (!is_string($timestamp)) { | ||
| return $timestamp; | ||
| } | ||
| if (!is_string($timestamp)) return $timestamp; |
There was a problem hiding this comment.
This change converts a multi-line if statement with braces to a single-line statement without them. The PSR-12 standard recommends always using braces for if statements to improve code clarity and prevent potential bugs when adding more lines to the block. The original code was more compliant with this standard.
if (!is_string($timestamp)) {
return $timestamp;
}| @@ -82,7 +82,7 @@ public static function sanitizeForSerialization($data, $type = null, $format = n | |||
| } | |||
| } | |||
| } else { | |||
| foreach ($data as $property => $value) { | |||
| foreach($data as $property => $value) { | |||
There was a problem hiding this comment.
This foreach statement is missing a space after the keyword. According to the PSR-12 coding standard, there must be one space after control structure keywords like foreach to ensure code consistency and readability. The previous version of the code was compliant with this rule.
foreach ($data as $property => $value) {| if (!is_string($timestamp)) { | ||
| return $timestamp; | ||
| } | ||
| if (!is_string($timestamp)) return $timestamp; |
There was a problem hiding this comment.
This change converts a multi-line if statement with braces to a single-line statement without them. The PSR-12 standard recommends always using braces for if statements to improve code clarity and prevent potential bugs when adding more lines to the block. The original code was more compliant with this standard.
if (!is_string($timestamp)) {
return $timestamp;
}| @@ -82,7 +82,7 @@ public static function sanitizeForSerialization($data, $type = null, $format = n | |||
| } | |||
| } | |||
| } else { | |||
| foreach ($data as $property => $value) { | |||
| foreach($data as $property => $value) { | |||
There was a problem hiding this comment.
This foreach statement is missing a space after the keyword. According to the PSR-12 coding standard, there must be one space after control structure keywords like foreach to ensure code consistency and readability. The previous version of the code was compliant with this rule.
foreach ($data as $property => $value) {| if (!is_string($timestamp)) { | ||
| return $timestamp; | ||
| } | ||
| if (!is_string($timestamp)) return $timestamp; |
There was a problem hiding this comment.
This change converts a multi-line if statement with braces to a single-line statement without them. The PSR-12 standard recommends always using braces for if statements to improve code clarity and prevent potential bugs when adding more lines to the block. The original code was more compliant with this standard.
if (!is_string($timestamp)) {
return $timestamp;
}
AdyenAutomationBot
force-pushed
the
sdk-automation/Webhooks
branch
5 times, most recently
from
c21182d to
ff077a6
Compare
AdyenAutomationBot
force-pushed
the
sdk-automation/Webhooks
branch
2 times, most recently
from
166d6ee to
a14da0b
Compare
AdyenAutomationBot
force-pushed
the
sdk-automation/Webhooks
branch
from
f9c4b34 to
ffcdb7c
Compare
|
OpenAPI spec files or templates have been modified on 29-08-2025 by commit.