-
Notifications
You must be signed in to change notification settings - Fork 113
[PaymentsAPIs] Code generation: update services and models #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request, generated automatically, updates the Adyen Payments APIs services and models. The changes primarily involve minor code formatting adjustments, PHPDoc comment updates, and removal of extraneous empty lines, reflecting an update to the underlying OpenAPI specification or code generation templates.
Highlights
- Code Formatting Adjustments: Minor adjustments were made to the syntax of 'foreach' loops, ensuring a consistent space after the 'foreach' keyword. Additionally, multi-line 'if' statements were condensed into single lines where appropriate.
- PHPDoc Comment Formatting: PHPDoc comments for '@param' and '@deprecated' tags were updated to include a space before their closing '*/', improving readability and consistency.
- Namespace Import Cleanup: Extraneous empty lines between 'namespace' declarations and 'use' statements were removed, streamlining the file structure.
- Trailing Newline Consistency: A trailing newline character was added to one file to ensure consistent file formatting across the codebase.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, generated from an OpenAPI specification, introduces several updates to services and models. While the changes are mostly automated, they've introduced a number of code style violations against the PSR-12 standard. My review focuses on correcting these issues, which include improper spacing in control structures, missing braces for if
statements, removal of required blank lines, and the addition of unnecessary trailing whitespace. Addressing these points will improve code quality, readability, and adherence to PHP community standards.
@@ -82,7 +82,7 @@ public static function sanitizeForSerialization($data, $type = null, $format = n | |||
} | |||
} | |||
} else { | |||
foreach ($data as $property => $value) { | |||
foreach($data as $property => $value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!is_string($timestamp)) { | ||
return $timestamp; | ||
} | ||
if (!is_string($timestamp)) return $timestamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -2070,7 +2070,7 @@ public function getShopperEmail() | |||
/** | |||
* Sets shopperEmail | |||
* | |||
* @param string $shopperEmail | |||
* @param string $shopperEmail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -2094,7 +2094,7 @@ public function getTelephoneNumber() | |||
/** | |||
* Sets telephoneNumber | |||
* | |||
* @param string $telephoneNumber | |||
* @param string $telephoneNumber |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -358,7 +358,7 @@ public function getShopperEmail() | |||
/** | |||
* Sets shopperEmail | |||
* | |||
* @param string $shopperEmail | |||
* @param string $shopperEmail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/Adyen/Service/RecurringApi.php
Outdated
@@ -58,7 +58,7 @@ public function createPermit(\Adyen\Model\Recurring\CreatePermitRequest $createP | |||
/** | |||
* Disable stored payment details | |||
* | |||
* @deprecated since Adyen Recurring API v68. | |||
* @deprecated since Adyen Recurring API v68. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/Adyen/Service/RecurringApi.php
Outdated
@@ -74,7 +74,7 @@ public function disable(\Adyen\Model\Recurring\DisableRequest $disableRequest, ? | |||
/** | |||
* Disable an existing permit. | |||
* | |||
* @deprecated since Adyen Recurring API v68. | |||
* @deprecated since Adyen Recurring API v68. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/Adyen/Service/RecurringApi.php
Outdated
@@ -90,7 +90,7 @@ public function disablePermit(\Adyen\Model\Recurring\DisablePermitRequest $disab | |||
/** | |||
* Get stored payment details | |||
* | |||
* @deprecated since Adyen Recurring API v68. | |||
* @deprecated since Adyen Recurring API v68. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/Adyen/Service/RecurringApi.php
Outdated
@@ -106,7 +106,7 @@ public function listRecurringDetails(\Adyen\Model\Recurring\RecurringDetailsRequ | |||
/** | |||
* Ask issuer to notify the shopper | |||
* | |||
* @deprecated since Adyen Recurring API v68. | |||
* @deprecated since Adyen Recurring API v68. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/Adyen/Service/RecurringApi.php
Outdated
@@ -122,7 +122,7 @@ public function notifyShopper(\Adyen\Model\Recurring\NotifyShopperRequest $notif | |||
/** | |||
* Schedule running the Account Updater | |||
* | |||
* @deprecated since Adyen Recurring API v68. | |||
* @deprecated since Adyen Recurring API v68. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8afe2dc
to
71bae28
Compare
ff86211
to
ba6d22c
Compare
1d5588d
to
06bed1d
Compare
|
OpenAPI spec files or templates have been modified on 29-08-2025 by commit.