Fix AccessoryView Updates, Support iOS 16+, Support Programatic Dismissal #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This also resolves #5 |
This comment was marked as outdated.
This comment was marked as outdated.
Expanded documentation for the `contextMenuAccessory` SwiftUI modifier, clarifying its variants and parameters. Added examples for both basic usage and programmatic dismissal. Updated iOS version badge from 18+ to 16+.
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the great work in starting this library and uncovering the hidden APIs!
When attempting to use it in my project, I ran into 3 key issues:
contextMenuAccessorydid not receive view updates during presentation, which meant if the view that changes were not renderedI resolved these issues in a fork, and now I am happy to help integrate a subset or all of them here.
To resolve this, I switched from a static XCFramework to am SPM library
The bug here was that the
_UIHostingView's root view was not updated inupdateUIViewAdded a
ContextMenuProxywhich is passed into the accessory view@ViewBuilderto expose a dismiss method, which internally calls upon theUIContextMenuInteraction