Draft
Conversation
Provini
changed the title
Contributor
Author
|
Converted to draft due to the upcoming rework of FPFC within SiraUtil. Will need to be adjusted to not patch latest build as it's now unnecessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to prevent the Head from getting unparented from
NoodleRoomOffset, as it already functions fine in FPFC.This should fix the head and saber transforms when viewing modhcarts with FPFC and resolve recent issues that reported odd note and saber transforms within FPFC.
This only checks if the original parent of the Head is
NoodleRoomOffset, however this would fix sabers as well as we don't execute the original method. This ensures FPFC doesn't break for Noodle maps that don't make use of these transforms, otherwise the saber would be in the head.Edit: Redid the change with a more simpler implementation.