Enhance PDF Export: Preserve Hyperlinks in Resume#1
Open
Talhadeveloperr wants to merge 1 commit intoAfif718:mainfrom
Open
Enhance PDF Export: Preserve Hyperlinks in Resume#1Talhadeveloperr wants to merge 1 commit intoAfif718:mainfrom
Talhadeveloperr wants to merge 1 commit intoAfif718:mainfrom
Conversation
|
Seems like incomplete commit. Only change is in package-lock.json. @Talhadeveloperr did you forget to commit rest? |
Author
|
My apologies,Now I have open the pull requests ,which changes I made 3
months ago
Thanks for your time and consideration
Kind regards
…On Tue, 3 Mar 2026 at 19:28, Manpreet Singh ***@***.***> wrote:
*manpreetbhasin* left a comment (Afif718/Resumify#1)
<#1 (comment)>
Seems like incomplete commit. Only change is in package-lock.json.
@Talhadeveloperr <https://github.com/Talhadeveloperr> did you forget to
commit rest?
—
Reply to this email directly, view it on GitHub
<#1 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFGUF3534ZCJUWIHDECOZYD4O3TZXAVCNFSM6AAAAACPWKN5NCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSOJRGQ2DQMRYGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the PDF export functionality in the Resume Maker project by ensuring that all hyperlinks (LinkedIn, GitHub.) remain clickable in the generated PDF.
Changes
html2pdf.jsto maintain proper hyperlinks.handleDownloadPDFfunction with proper options for high-quality PDF export.Html2PdfOptionsand.save()method.useCORS: trueand higherhtml2canvasscale for better rendering of SVG icons and fonts.Benefits
Notes
No changes were made to core resume templates. This update strictly improves PDF export behavior.
This PR focuses on improving PDF export with proper hyperlinks. I am also working on other enhancements and will submit updates for additional features in future PRs.