fix(main): log errors from run() helper — closes #51#93
Merged
Conversation
run() silently swallowed all command errors via the ignored return value from cmd.Run(). Add log.Printf on failure so install/setup failures are visible in the terminal output. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jpleva91
added a commit
that referenced
this pull request
Mar 31, 2026
Recovered broken worktree (incomplete WIP #51 fix left build broken). Stashed WIP, fixed #51 properly in PR #93 (log run() errors). PR #89 merged — 25 tests, closes #68 + #66. Issue #92 (Preflight/Goose) triaged P2. PR budget 2/3. Sprint: P2 bug sweep (#52, #65) + dogfood readiness. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run()helper silently ignoring all command errors (brew, ollama, npm, etc.)log.Printfoncmd.Run()failure so install/setup failures are visibleTest plan
go build ./cmd/shellforge/passesgo test ./...— 25/25 pass (governance, intent, normalizer)🤖 Generated with Claude Code