Add mouse side-buttons navigation #256#257
Draft
Arskan17 wants to merge 2 commits intoAgregoreWeb:masterfrom
Draft
Add mouse side-buttons navigation #256#257Arskan17 wants to merge 2 commits intoAgregoreWeb:masterfrom
Arskan17 wants to merge 2 commits intoAgregoreWeb:masterfrom
Conversation
- Added the listeners that check for button codes, but I can't check with my mouse yet since it doesn't emit the usual supported codes. - Also added listeners for trackpad swipes left&right.
added some gestures navigation logic
Arskan17
changed the title
RangerMauve
reviewed
Feb 8, 2024
Member
RangerMauve
left a comment
RangerMauve
left a comment
There was a problem hiding this comment.
Sadly I don't have a windows machine to test the mouse thing. I have managed to get my mouse 4&mouse 5 stuff working in Agregore on Linux however.
The right click drag thing is really neat. It'd be nice if there was a way to cancel the pop up menu when you drag and avoid accidentally "dragging" the text in the url bar.
Contributor
Author
|
Thanks for taking a look ^^ Yeh... I'll look some more into that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So uhm... I tried working on this and reached a little bit of a pickle.
I implemented a bunch of things just to find out a day later that my mouse's side-buttons aren't apparently registered.
I also tried to implement track-pad swipe gestures, but that's still a working progress.
While rabbit holing all over the internet I found out that JavaScript usually registers the side buttons
(mouse's 4th and 5th button)for forward and back with code4and3respectively.For context, I use a
Logitech mx master 3onlinux mint, for which they don't have a native app support...I used Mouse Test to check if they were getting registered, but they aren't...
So
TLDRI can't test what I did, at least not on my current OS.I might need to dual-boot windows and see. Originally thought of spinning up a vm real quick, but it came to mind that the vm might just get back the codes sent from my OS in the first place...
But in the mean time, could anyone test it and see?
Would really appreciate some feedback :)