Make LocalNotification a static class + add carthage support + update to swift 2.2#4
Open
AndrewSB wants to merge 4 commits intoAhmettKeskin:masterfrom
Open
Make LocalNotification a static class + add carthage support + update to swift 2.2#4AndrewSB wants to merge 4 commits intoAhmettKeskin:masterfrom
AndrewSB wants to merge 4 commits intoAhmettKeskin:masterfrom
Conversation
Author
|
@AhmettKeskin: I'd love to get this merged in so I can delete my fork, let me know if theres anything I can do to get this to a state where it can be merged in |
Owner
|
Hi Andrew, Thanks for your contribution. I know you sent pr long time ago but that times i didnt see its necessary. Now i fetch and check, you need update PR according to Swift 3 & xCode 8.x . After that if it works, i can merge it o/ |
Author
|
@AhmettKeskin I think I rebased correctly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know if you have any questions! Thought this was more elegant