Skip to content

Use error types and messages from the API response #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EthanBehrends wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use error types and messages from the API response #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions build/airtable.browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,28 +158,28 @@ var Base = /** @class */ (function () {
var _a = (body !== null && body !== void 0 ? body : { error: {} }).error, error = _a === void 0 ? {} : _a;
var type = error.type, message = error.message;
if (statusCode === 401) {
return new airtable_error_1.default('AUTHENTICATION_REQUIRED', 'You should provide valid api key to perform this operation', statusCode);
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'AUTHENTICATION_REQUIRED', message !== null && message !== void 0 ? message : 'You should provide valid api key to perform this operation', statusCode);
}
else if (statusCode === 403) {
return new airtable_error_1.default('NOT_AUTHORIZED', 'You are not authorized to perform this operation', statusCode);
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'NOT_AUTHORIZED', message !== null && message !== void 0 ? message : 'You are not authorized to perform this operation', statusCode);
}
else if (statusCode === 404) {
return new airtable_error_1.default('NOT_FOUND', message !== null && message !== void 0 ? message : 'Could not find what you are looking for', statusCode);
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'NOT_FOUND', message !== null && message !== void 0 ? message : 'Could not find what you are looking for', statusCode);
}
else if (statusCode === 413) {
return new airtable_error_1.default('REQUEST_TOO_LARGE', 'Request body is too large', statusCode);
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'REQUEST_TOO_LARGE', message !== null && message !== void 0 ? message : 'Request body is too large', statusCode);
}
else if (statusCode === 422) {
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'UNPROCESSABLE_ENTITY', message !== null && message !== void 0 ? message : 'The operation cannot be processed', statusCode);
}
else if (statusCode === 429) {
return new airtable_error_1.default('TOO_MANY_REQUESTS', 'You have made too many requests in a short period of time. Please retry your request later', statusCode);
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'TOO_MANY_REQUESTS', message !== null && message !== void 0 ? message : 'You have made too many requests in a short period of time. Please retry your request later', statusCode);
}
else if (statusCode === 500) {
return new airtable_error_1.default('SERVER_ERROR', 'Try again. If the problem persists, contact support.', statusCode);
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'SERVER_ERROR', message !== null && message !== void 0 ? message : 'Try again. If the problem persists, contact support.', statusCode);
}
else if (statusCode === 503) {
return new airtable_error_1.default('SERVICE_UNAVAILABLE', 'The service is temporarily unavailable. Please retry shortly.', statusCode);
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'SERVICE_UNAVAILABLE', message !== null && message !== void 0 ? message : 'The service is temporarily unavailable. Please retry shortly.', statusCode);
}
else if (statusCode >= 400) {
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'UNEXPECTED_ERROR', message !== null && message !== void 0 ? message : 'An unexpected error occurred', statusCode);
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 16 additions & 12 deletions src/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,24 +154,28 @@ class Base {

if (statusCode === 401) {
return new AirtableError(
'AUTHENTICATION_REQUIRED',
'You should provide valid api key to perform this operation',
type ?? 'AUTHENTICATION_REQUIRED',
message ?? 'You should provide valid api key to perform this operation',
statusCode
);
} else if (statusCode === 403) {
return new AirtableError(
'NOT_AUTHORIZED',
'You are not authorized to perform this operation',
type ?? 'NOT_AUTHORIZED',
message ?? 'You are not authorized to perform this operation',
statusCode
);
} else if (statusCode === 404) {
return new AirtableError(
'NOT_FOUND',
type ?? 'NOT_FOUND',
message ?? 'Could not find what you are looking for',
statusCode
);
} else if (statusCode === 413) {
return new AirtableError('REQUEST_TOO_LARGE', 'Request body is too large', statusCode);
return new AirtableError(
type ?? 'REQUEST_TOO_LARGE',
message ?? 'Request body is too large',
statusCode
);
} else if (statusCode === 422) {
return new AirtableError(
type ?? 'UNPROCESSABLE_ENTITY',
Expand All @@ -180,20 +184,20 @@ class Base {
);
} else if (statusCode === 429) {
return new AirtableError(
'TOO_MANY_REQUESTS',
'You have made too many requests in a short period of time. Please retry your request later',
type ?? 'TOO_MANY_REQUESTS',
message ?? 'You have made too many requests in a short period of time. Please retry your request later',
statusCode
);
} else if (statusCode === 500) {
return new AirtableError(
'SERVER_ERROR',
'Try again. If the problem persists, contact support.',
type ?? 'SERVER_ERROR',
message ?? 'Try again. If the problem persists, contact support.',
statusCode
);
} else if (statusCode === 503) {
return new AirtableError(
'SERVICE_UNAVAILABLE',
'The service is temporarily unavailable. Please retry shortly.',
type ?? 'SERVICE_UNAVAILABLE',
message ?? 'The service is temporarily unavailable. Please retry shortly.',
statusCode
);
} else if (statusCode >= 400) {
Expand Down
14 changes: 7 additions & 7 deletions test/test_files/airtable.browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,28 +158,28 @@ var Base = /** @class */ (function () {
var _a = (body !== null && body !== void 0 ? body : { error: {} }).error, error = _a === void 0 ? {} : _a;
var type = error.type, message = error.message;
if (statusCode === 401) {
return new airtable_error_1.default('AUTHENTICATION_REQUIRED', 'You should provide valid api key to perform this operation', statusCode);
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'AUTHENTICATION_REQUIRED', message !== null && message !== void 0 ? message : 'You should provide valid api key to perform this operation', statusCode);
}
else if (statusCode === 403) {
return new airtable_error_1.default('NOT_AUTHORIZED', 'You are not authorized to perform this operation', statusCode);
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'NOT_AUTHORIZED', message !== null && message !== void 0 ? message : 'You are not authorized to perform this operation', statusCode);
}
else if (statusCode === 404) {
return new airtable_error_1.default('NOT_FOUND', message !== null && message !== void 0 ? message : 'Could not find what you are looking for', statusCode);
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'NOT_FOUND', message !== null && message !== void 0 ? message : 'Could not find what you are looking for', statusCode);
}
else if (statusCode === 413) {
return new airtable_error_1.default('REQUEST_TOO_LARGE', 'Request body is too large', statusCode);
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'REQUEST_TOO_LARGE', message !== null && message !== void 0 ? message : 'Request body is too large', statusCode);
}
else if (statusCode === 422) {
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'UNPROCESSABLE_ENTITY', message !== null && message !== void 0 ? message : 'The operation cannot be processed', statusCode);
}
else if (statusCode === 429) {
return new airtable_error_1.default('TOO_MANY_REQUESTS', 'You have made too many requests in a short period of time. Please retry your request later', statusCode);
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'TOO_MANY_REQUESTS', message !== null && message !== void 0 ? message : 'You have made too many requests in a short period of time. Please retry your request later', statusCode);
}
else if (statusCode === 500) {
return new airtable_error_1.default('SERVER_ERROR', 'Try again. If the problem persists, contact support.', statusCode);
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'SERVER_ERROR', message !== null && message !== void 0 ? message : 'Try again. If the problem persists, contact support.', statusCode);
}
else if (statusCode === 503) {
return new airtable_error_1.default('SERVICE_UNAVAILABLE', 'The service is temporarily unavailable. Please retry shortly.', statusCode);
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'SERVICE_UNAVAILABLE', message !== null && message !== void 0 ? message : 'The service is temporarily unavailable. Please retry shortly.', statusCode);
}
else if (statusCode >= 400) {
return new airtable_error_1.default(type !== null && type !== void 0 ? type : 'UNEXPECTED_ERROR', message !== null && message !== void 0 ? message : 'An unexpected error occurred', statusCode);
Expand Down