fix(plotting): refactor combi_plot with improved visual API #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move combi_plot from SDCAnalysis to plotting.py as standalone function - Add fontsize hierarchy: fontsize, tick_fontsize, label_fontsize, colorbar_fontsize - Add dynamic wspace/hspace calculation based on figsize - Add n_ticks parameter for controlling axis tick count - Add dpi parameter with 150 default - Support both datetime and integer indexes - Remove auto-generated title (now opt-in) - Move ts2/mc2 x-axis ticks to top to avoid mc1 clash - Remove plot_two_way_sdc (replaced by combi_plot) - Inline two_way_plot method in SDCAnalysis Fixes combi_plot visual issues and improves modularity.
- Add Usage section to README with tc_signal example - Add examples/basic_usage.py with transient correlation demo - Add sdc_example.png showing combi_plot output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes and improves the
combi_plotfunctionality:Changes
Refactoring:
combi_plotfromSDCAnalysisclass to standalone function inplotting.pyplot_two_way_sdcfunctionSDCAnalysis.combi_plot()is now a thin wrapper callingplotting.combi_plot()New features:
fontsize(base),tick_fontsize,label_fontsize,colorbar_fontsizewspace/hspaceauto-calculated fromfigsize(can be overridden)title=parameterVisual fixes:
Documentation:
tc_signalexampleexamples/basic_usage.pywith transient correlation demoFixes visual issues in combi_plot.
Closes #4 #10 #13