Skip to content

fix(main): duplicated task that are actually the same #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benureau wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −1
Open

fix(main): duplicated task that are actually the same #144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33a08c0
fix duplicated task that are actually the same
benureau Jan 7, 2026
781fb47
Merge branch 'main' into fix/duplicated_tasks
benureau Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/eval_framework/tasks/task_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from typing import Any

from eval_framework.tasks.base import BaseTask
from eval_framework.tasks.registry import is_registered, register_task
from eval_framework.tasks.registry import is_registered, register_task, get_task

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -64,6 +64,9 @@ def load_extra_tasks(module_paths: Sequence[str | os.PathLike]) -> None:
logger.info(f"[User Task Loader] Skipping {obj.__module__} - no NAME attribute present.")
else:
if is_registered(obj.NAME):
if get_task(obj.NAME) is obj: # same task, no need to do anything
continue

# two classes with the same NAME attribute
logger.info(obj.__module__)

Expand Down
Loading