Skip to content

Conversation

@Alex-Burmak
Copy link
Owner

No description provided.

@github-actions
Copy link

@CodiumAI-Agent /describe

@github-actions
Copy link

@CodiumAI-Agent /improve

@QodoAI-Agent
Copy link

Title

Test PR


PR Type

Enhancement, Documentation


Description

  • Integrate uv for project management

  • Migrate build and lint to Hatchling config

  • Load dynamic version from version.txt

  • Refactor code to use f-strings


Changes walkthrough 📝

Relevant files
Enhancement
2 files
__init__.py
Load version from version.txt via pkg_resources                   
+3/-1     
storage_configuration.py
Refactor endpoint URL assembly with f-strings                       
+3/-3     
Formatting
8 files
database_metadata.py
Use f-string in replica metadata error                                     
+1/-3     
migration.py
Use f-string in create_temp_db query                                         
+3/-6     
formatting.py
Format negative bytes with f-string                                           
+1/-1     
clickhouse_client.py
Use f-string in command failure RuntimeError                         
+1/-3     
utils.py
Convert string match formatting to f-string                           
+3/-3     
utils.py
Use f-strings in shell command error message                         
+2/-2     
ch_resetup_state.py
Use f-string for request URL formatting                                   
+1/-1     
keeper_commands.py
Use f-string for zk alive path creation                                   
+1/-1     
Error handling
1 files
exceptions.py
Simplify exception messages with f-strings                             
+2/-10   
Configuration changes
10 files
action.yml
Remove custom setup_dependencies action                                   
+0/-31   
test_clickhouse_version.yml
Replace setup_dependencies with setup-uv action                   
+1/-3     
workflow.yml
Switch CI setup to use `uv` action                                             
+4/-8     
.pylintrc
Remove outdated pylint configuration file                               
+0/-648 
.python-version
Add Python version file                                                                   
+1/-0     
Dockerfile-deb-build
Install `uv` and remove poetry steps                                         
+5/-5     
Makefile
Migrate Makefile targets from Poetry to `uv`                         
+59/-157
control
Bump Python version requirement to 3.9                                     
+1/-1     
rules
Use python3 instead of custom PYTHON variable                       
+2/-12   
pyproject.toml
Overhaul project config: hatchling and dependencies           
+148/-106
Documentation
2 files
AUTHORS
Update author names and add new maintainers                           
+4/-1     
README.md
Update setup instructions to use `uv`                                       
+1/-4     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @QodoAI-Agent
    Copy link

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Specify Python version

    Add a with block specifying python-version for the astral-sh/setup-uv@v5 action to
    ensure the workflow uses the intended Python version (e.g., 3.11). Without it, the
    runner may default to an unsupported Python version and break builds.

    .github/workflows/test_clickhouse_version.yml [31]

     - uses: astral-sh/setup-uv@v5
    +  with:
    +    python-version: "3.11"
    Suggestion importance[1-10]: 5

    __

    Why: Specifying python-version for astral-sh/setup-uv@v5 ensures a consistent Python environment and prevents defaults from breaking builds.

    Low

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants