Skip to content

Conversation

@Alex-Burmak
Copy link
Owner

@Alex-Burmak Alex-Burmak commented May 22, 2025

Summary by Sourcery

Add robust environment validations to the Makefile, introduce a CLICKHOUSE_VERSION setting, bump the Python requirement and tighten dependency constraints in pyproject.toml, and refresh the lock file.

Enhancements:

  • Add CLICKHOUSE_VERSION variable and new Makefile targets to check for uv, Docker, and Docker Compose before running setup, build, or integration tests
  • Bump requires-python to >=3.9 and tighten version bounds for core and dev dependencies in pyproject.toml, then update uv.lock
  • Refactor CLI and utility modules for consistent parameter formatting and streamline DeepDiff invocation

@sourcery-ai
Copy link

sourcery-ai bot commented May 22, 2025

Reviewer's Guide

This PR enhances build and environment validation in the Makefile, tightens Python version and dependency constraints in pyproject.toml, and applies minor refactorings to CLI utilities and code for consistency.

File-Level Changes

Change Details Files
Enhanced Makefile environment and build validations
  • Introduce CLICKHOUSE_VERSION default variable
  • Replace legacy check-environment with check-uv
  • Add check-docker and check-docker-compose targets
  • Require new checks in setup, test-integration, build-deb-package targets
Makefile
Updated Python requirement and dependency constraints
  • Bump requires-python from >=3.8 to >=3.9
  • Tighten ranges for click, deepdiff, pyyaml, requests
  • Remove typing-extensions and CFFI pins, update setuptools constraint
  • Upgrade dev-group packages: docker, black, pyfakefs, isort
pyproject.toml
Refactored CLI object_storage_group assignment
  • Consolidate ctx.obj["disk_configuration"] assignment into one expression
  • Adjust indentation and parentheses for readability
ch_tools/chadmin/cli/object_storage_group.py
Simplified DeepDiff invocation parameters
  • Inline ignore_type_in_groups list directly into call
  • Remove temporary variable for ignore_type_in_groups
ch_tools/common/cli/utils.py
Standardized function signature formatting
  • Add trailing comma to skip_ignoring parameter in s3_object_storage_iterator
ch_tools/chadmin/internal/object_storage/s3_iterator.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Alex-Burmak - I've reviewed your changes and found some issues that need to be addressed.

  • Please add the new check-uv, check-docker, and check-docker-compose targets to the Makefile’s help section so they’re visible when running make help.
  • Double-check that dropping the typing-extensions dependency still works on Python 3.9, as some typing features may require it on older versions.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant