-
Notifications
You must be signed in to change notification settings - Fork 0
Test PR 3 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Test PR 3 #3
Conversation
Reviewer's GuideThis PR enhances build and environment validation in the Makefile, tightens Python version and dependency constraints in pyproject.toml, and applies minor refactorings to CLI utilities and code for consistency. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Alex-Burmak - I've reviewed your changes and found some issues that need to be addressed.
- Please add the new check-uv, check-docker, and check-docker-compose targets to the Makefile’s help section so they’re visible when running
make help. - Double-check that dropping the typing-extensions dependency still works on Python 3.9, as some typing features may require it on older versions.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Add robust environment validations to the Makefile, introduce a CLICKHOUSE_VERSION setting, bump the Python requirement and tighten dependency constraints in pyproject.toml, and refresh the lock file.
Enhancements: