Conversation
…eanup of methods and strings
nndownload/nndownload.py
Outdated
| @@ -148,6 +148,7 @@ | |||
| "quality": "super_high", | |||
There was a problem hiding this comment.
This needs to be replaced by the highest quality that is acquired from params (params['program']['stream']['maxQuality']) because super_high is no longer the best quality for years (we have 6m and 12m now).
There was a problem hiding this comment.
Is 12Mbps exclusive to some type of user/broadcast type? I tried setting up a broadcast now on premium and it seems the max is 6.
There was a problem hiding this comment.
Probably only the "official" ones can do. I can't find a 12M rn but here is a 8M one: https://live.nicovideo.jp/watch/lv347308094
Also note that the actual bitrate is often much lower.
|
I can help writing the comment downloading function once you're done. I have a working one myself. Do note the proto schema data is directly copied from https://github.com/tsukumijima/NDGRClient (MIT) which was imported from https://github.com/n-air-app/nicolive-comment-protobuf (also MIT); I don't dump them myself. |
Resolves #11. This also fixes
get_media_from_manifestto actually respect the media type.-cis not supported-headers. This adds a warning to follow that work in On-air Niconama stream links #203