Revise Copilot triggers. Request completion on demand#1
Revise Copilot triggers. Request completion on demand#1verte-zerg wants to merge 19 commits intoAlexanderDickie:copilotfrom
Conversation
being able to add/subtract positions is very handy when writing rendering code
The line annotation as implemented in helix-editor#5420 had two shortcomings: * It required the height of virtual text lines to be known ahead time * It checked for line anchors at every grapheme The first problem made the API impractical to use in practice because almost all virtual text needs to be softwrapped. For example inline diagnostics should be softwrapped to avoid cutting off the diagnostic message (as no scrolling is possible). While more complex virtual text like side by side diffs must dynamically calculate the number of empty lines two align two documents (which requires taking account both softwrap and virtual text). To address this, the API has been refactored to use a trait. The second issue caused some performance overhead and unnecessarily complicated the `DocumentFormatter`. It was addressed by only calling the trait mentioned above at line breaks (instead of always). This allows offers additional flexibility to annotations as it offers the flexibility to align lines (needed for side by side diffs).
This commit brings the text decoration API inline with the LineAnnotation API (so they are consistent) resulting in a single streamlined API instead of multiple ADHOK callbacks.
|
Hi, thanks for the pr! Given this do you think it’s still necessary that The completion iteration function should be added, I would also like the ability to hide a completion too, eg either have Please feel free to make other suggestions/prs for improvements, I havent been using this branch much (I mainly use c# atm which I cant use with helix as there is no good lsp) so Im interested how you find this |
841c088 to
076d8dd
Compare
076d8dd to
bca6737
Compare
bca6737 to
811ba4e
Compare
copilot_show_completioncopilot_show_completionagain