Open
Conversation
mettizik
reviewed
Nov 15, 2018
mettizik
left a comment
mettizik
left a comment
There was a problem hiding this comment.
Слишком большие шаги, видно что ты уже понимал, как хочешь реализовать функцию и просто писал тесты под эту реализацию. А надо отталкиваться от тестов, а не наоборот
| std::map<std::string, size_t> words = SeparateWords("hello bro"); | ||
| EXPECT_EQ(1, words.size()); | ||
| words_mt words = SeparateWords("hello"); | ||
| ASSERT_EQ(1, words.size()); |
| EXPECT_EQ(1, words.size()); | ||
| words_mt words = SeparateWords("hello"); | ||
| ASSERT_EQ(1, words.size()); | ||
| EXPECT_TRUE(words.find("hello") != words.end()); |
|
|
||
| words_mt SeparateWords(const std::string& phrase) | ||
| { | ||
| const size_t index = phrase.find_first_of(wordSeparator); |
There was a problem hiding this comment.
это уже имплемент, а не рефакторинг - написанный тест не нуждается вэтом функционале
| const size_t index = phrase.find_first_of(wordSeparator); | ||
| return {{phrase.substr(0, index), 1}}; | ||
|
|
||
| if (index != std::string::npos) |
| words_mt SeparateWords(const std::string& phrase) | ||
| { | ||
| const size_t index = phrase.find_first_of(wordSeparator); | ||
| std::string separatedPhrase = phrase; |
There was a problem hiding this comment.
тест был сложноват, но он всё равно не нуждается в таком кол-ве функционала, как по мне
| EXPECT_EQ(1, words["hello"]); | ||
| } | ||
|
|
||
| TEST(WordsCount, TestTrimWord) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.