add prefer-album-artist to mpris module #4084
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extends PlayerInfo to include an albumartist field; reads the xesam:albumartist field into it, and substitutes it for the artist value if the appropriate bool is true (default false, so no change to existing usecases).
I also thought about adding a separate
Mpris::getAlbumArtistStr
method, but held off since it doesn't seem strictly necessary (e.g. would be kinda clunky to use in a format string as it might not be present always). I could instead split this out to that & have it fall back to the artist tag if no albumArtist is set? idk.(I'll add a documentation commit once this looks good, if this is all fine!)