Skip to content

add prefer-album-artist to mpris module #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PandorasFox
Copy link

image

extends PlayerInfo to include an albumartist field; reads the xesam:albumartist field into it, and substitutes it for the artist value if the appropriate bool is true (default false, so no change to existing usecases).

I also thought about adding a separate Mpris::getAlbumArtistStr method, but held off since it doesn't seem strictly necessary (e.g. would be kinda clunky to use in a format string as it might not be present always). I could instead split this out to that & have it fall back to the artist tag if no albumArtist is set? idk.

(I'll add a documentation commit once this looks good, if this is all fine!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant