Make it so location saves correctly for rooms added by World Edits#278
Open
FrivolousBorks wants to merge 3 commits intoAlexofp:devfrom
Open
Make it so location saves correctly for rooms added by World Edits#278FrivolousBorks wants to merge 3 commits intoAlexofp:devfrom
FrivolousBorks wants to merge 3 commits intoAlexofp:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's try this one more time.
I noticed that saving in a room that was added by a World Edit always caused the player's location to get reset. Separately, I noticed that saving during a scene that happened to take place in an added room caused the camera to have a moment.
I have fixed these problems. The player's location is now checked after World Edits are applied, and the camera aim is saved at the start of scenes.
I also fixed a softlock that happens when loading a save that's in the middle of a scene that doesn't exist. It made testing this annoying.