Skip to content

Update heating curve links and descriptions in README to match 4.2.1 release.#147

Open
sergeantd83 wants to merge 2 commits intoAlexwijn:developfrom
sergeantd83:develop
Open

Update heating curve links and descriptions in README to match 4.2.1 release.#147
sergeantd83 wants to merge 2 commits intoAlexwijn:developfrom
sergeantd83:develop

Conversation

@sergeantd83
Copy link
Collaborator

@sergeantd83 sergeantd83 commented Jan 14, 2026

…release

Pull Request Template

Summary

  • I have added a clear, concise title and description.
  • The description includes what has changed and why it matters.

Checklist

  • I followed the coding style guidelines (PEP8, Home Assistant patterns).
  • All new code is typed with type hints where appropriate.
  • I added or updated unit tests that cover my changes.
  • Tests run locally and on CI without errors.
  • Documentation updates (README, docs, comments) are included if relevant.

Screenshots / Visuals

(Add screenshots if the PR introduces UI changes.)

Additional Notes

(Any extra information for reviewers.)

Summary by CodeRabbit

  • Documentation
    • Consolidated radiator options into a single "Radiators or Mixed Systems" heating curve
    • Consolidated underfloor (UFH) options into a single "Precision Curve for UFH"
    • Updated hyperlinks to point to the consolidated curve entries (Desmos links preserved)
    • Minor typographical inconsistency ("Recommented") remains in the text

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 14, 2026

Walkthrough

README.md updated to consolidate multiple radiator and underfloor heating curve entries into single "Precision Curve" entries for each system type; section labels adjusted (e.g., "Radiators or Mixed Systems"); Desmos links preserved and a typographical inconsistency ("Recommented") remains.

Changes

Cohort / File(s) Change Summary
Documentation
README.md
Renamed Radiators section to "Radiators or Mixed Systems"; consolidated three radiator curves into a single "Precision Curve for Radiators or Mixed Systems"; consolidated three UFH curves into a single "Precision Curve for UFH"; Desmos links retained; minor typo ("Recommented") persists.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • Alexwijn
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating heating curve links and descriptions in the README to match the 4.2.1 release, which aligns with the summary of consolidating radiator/UFH curves and updating documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc4440d and 4baab4d.

📒 Files selected for processing (1)
  • README.md
🔇 Additional comments (2)
README.md (2)

218-218: Verify that the UFH Desmos calculator link matches the 4.2.1 release.

The link formatting is correct and consistent with the Radiators section above. However, please confirm that this Desmos calculator URL (https://www.desmos.com/calculator/i7f7uuyaoz) is the correct/updated version for the 4.2.1 release.


214-215: Desmos calculator link verified for 4.2.1 release.

The URL (https://www.desmos.com/calculator/spfvsid4ds) is confirmed as the correct heating curve calculator for the 4.2.1 release. Spelling is correct and formatting is proper.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@README.md`:
- Line 214: The heading text "Radiators or Mixed Syestems:" contains a spelling
mistake; update that exact string (look for the heading "Radiators or Mixed
Syestems:") to read "Radiators or Mixed Systems:" so "Syestems" is corrected to
"Systems".
- Around line 214-218: Fix the spelling typo in the heading string "Radiators or
Mixed Syestems:" by changing it to "Radiators or Mixed Systems:" and while here
verify the two Desmos links (https://www.desmos.com/calculator/spfvsid4ds and
https://www.desmos.com/calculator/i7f7uuyaoz) remain unchanged and working;
update only the misspelled heading text (the label used in the README) and do
not alter the URLs or their formatting.
📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4db6ce and dc4440d.

📒 Files selected for processing (1)
  • README.md
🧰 Additional context used
🪛 LanguageTool
README.md

[grammar] ~214-~214: Ensure spelling is correct
Context: ...ilable options are: Radiators or Mixed Syestems: - [Precision Curve for Radiators or Mixed S...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant