Sourcery Starbot ⭐ refactored AlfiyaZi/jaeger-client-python

jaeger_client/TUDPTransport.py

@@ -30,10 +30,7 @@ def __init__(self, host, port, blocking=False):
         self.transport_host = host
         self.transport_port = port
         self.transport_sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
-        if blocking:
-            blocking = 1
-        else:
-            blocking = 0
+        blocking = 1 if blocking else 0
         self.transport_sock.setblocking(blocking)
 
     def write(self, buf):

jaeger_client/config.py

@@ -395,7 +395,7 @@ def new_tracer(self, io_loop=None):
         if self.logging:
             reporter = CompositeReporter(reporter, LoggingReporter(logger))
 
-        if not self.throttler_group() is None:
+        if self.throttler_group() is not None:
             throttler = RemoteThrottler(
                 channel,
                 self.service_name,

jaeger_client/metrics/prometheus.py

@@ -29,10 +29,7 @@ def __init__(self, namespace='', service_name_label=None):
     def _get_tag_name_list(self, tags):
         if tags is None:
             return []
-        tag_name_list = []
-        for key in tags.keys():
-            tag_name_list.append(key)
-        return tag_name_list
+        return [key for key in tags.keys()]
 
     def _get_metric(self, metricType, name, tags):
         if self._service_name_label:

jaeger_client/rate_limiter.py

@@ -66,5 +66,4 @@ def _update_balance(self):
         elapsed_time = current_time - self.last_tick
         self.last_tick = current_time
         self.balance += elapsed_time * self.credits_per_second
-        if self.balance > self.max_balance:
-            self.balance = self.max_balance
+        self.balance = min(self.balance, self.max_balance)

jaeger_client/reporter.py

@@ -67,7 +67,7 @@ def get_spans(self):
 class LoggingReporter(NullReporter):
     """Logs all spans."""
     def __init__(self, logger=None):
-        self.logger = logger if logger else default_logger
+        self.logger = logger or default_logger
 
     def report_span(self, span):
         self.logger.info('Reporting span %s', span)

jaeger_client/span.py

@@ -124,14 +124,15 @@ def _set_sampling_priority(self, value):
 
     def log_kv(self, key_values, timestamp=None):
         if self.is_sampled():
-            timestamp = timestamp if timestamp else time.time()
+            timestamp = timestamp or time.time()
             # TODO handle exception logging, 'python.exception.type' etc.
             log = thrift.make_log(
-                timestamp=timestamp if timestamp else time.time(),
+                timestamp=timestamp or time.time(),
                 fields=key_values,
                 max_length=self._tracer.max_tag_value_length,
                 max_traceback_length=self._tracer.max_traceback_length,
             )
+
             with self.update_lock:
                 self.logs.append(log)
         return self
@@ -165,8 +166,11 @@ def is_debug(self):
     def is_rpc(self):
         for tag in self.tags:
             if tag.key == ext_tags.SPAN_KIND:
-                return tag.vStr == ext_tags.SPAN_KIND_RPC_CLIENT or \
-                    tag.vStr == ext_tags.SPAN_KIND_RPC_SERVER
+                return tag.vStr in [
+                    ext_tags.SPAN_KIND_RPC_CLIENT,
+                    ext_tags.SPAN_KIND_RPC_SERVER,
+                ]
+
         return False
 
     def is_rpc_client(self):

jaeger_client/thrift.py

@@ -193,15 +193,19 @@ def make_ref_type(span_ref_type):
 def make_references(references):
     if not references:
         return None
-    list_of_span_refs = list()
-    for span_ref in references:
-        list_of_span_refs.append(ttypes.SpanRef(
+    return [
+        ttypes.SpanRef(
             refType=make_ref_type(span_ref.type),
-            traceIdLow=id_to_int(_id_to_low(span_ref.referenced_context.trace_id)),
-            traceIdHigh=id_to_int(_id_to_high(span_ref.referenced_context.trace_id)),
+            traceIdLow=id_to_int(
+                _id_to_low(span_ref.referenced_context.trace_id)
+            ),
+            traceIdHigh=id_to_int(
+                _id_to_high(span_ref.referenced_context.trace_id)
+            ),
             spanId=id_to_int(span_ref.referenced_context.span_id),
-        ))
-    return list_of_span_refs
+        )
+        for span_ref in references
+    ]
 
 
 def make_jaeger_batch(spans, process):