This repository was archived by the owner on Jan 22, 2024. It is now read-only.
MNT-20203 Improper Output Neutralization for Logs CWE ID 117#91
Open
LMRob wants to merge 1 commit intoAlfresco:developfrom
Open
MNT-20203 Improper Output Neutralization for Logs CWE ID 117#91LMRob wants to merge 1 commit intoAlfresco:developfrom
LMRob wants to merge 1 commit intoAlfresco:developfrom
Conversation
A function call could result in a log forging attack. Writing untrusted data into a log file allows an attacker to forge log entries or inject malicious content into log files. Corrupted log files can be used to cover an attacker's tracks or as a delivery mechanism for an attack on a log viewing or processing utility. For example, if a web administrator uses a browser-based utility to review logs, a cross-site scripting attack might be possible. - added a new java class to neutralize logs output - imported esapi library to encode logs for html output - override log4j to use new custom layout class as the layout pattern for share.log
|
I believe the same comments apply here as do from @skopf on the sibling PR for the remote-api project - see Alfresco/alfresco-remote-api#145 (comment) |
Author
|
Thanks Mike. I have responded with design comments / options in JIRA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A function call could result in a log forging attack. Writing untrusted data into a log file allows an attacker to forge log entries or inject malicious content into log files. Corrupted log files can be used to cover an attacker's tracks or as a delivery mechanism for an attack on a log viewing or processing utility. For example, if a web administrator uses a browser-based utility to review logs, a cross-site scripting attack might be possible.