[ACS-10385] Fix missing "WWW-Authenticate" header#72
Merged
cezary-witkowski merged 3 commits intosupport/SP/10.Nfrom Oct 1, 2025
Merged
[ACS-10385] Fix missing "WWW-Authenticate" header#72cezary-witkowski merged 3 commits intosupport/SP/10.Nfrom
cezary-witkowski merged 3 commits intosupport/SP/10.Nfrom
Conversation
…the response should be considered to be committed and should not be written to". Looks like Tomcat 10 is stricter with this method's contract.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a compatibility issue with Tomcat 10 by reordering HTTP response operations to comply with the sendError method contract. The change ensures the "WWW-Authenticate" header is set before calling sendError, which commits the response.
- Moved the
WWW-Authenticateheader setting to occur before thesendErrorcall
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kmagdziarz
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation and POC:
https://hyland.atlassian.net/browse/MNT-24530?focusedCommentId=2558591