Open
Conversation
Амортизационный анализ
Depreciation analysis
…нализ алгоритмов.pdf
LostPointer
approved these changes
Mar 23, 2024
LostPointer
requested changes
Jun 15, 2024
| : data(_data), prevptr(_prev) {} | ||
| StackNode() : data(), prevptr(nullptr) {} | ||
| T data; | ||
| StackNode<T> *prevptr; |
| int Pop(); | ||
| Stack() : top(nullptr), size(0) {} | ||
| void push(T value); | ||
| T pop(); |
| void push(T value); | ||
| T pop(); | ||
| T getTop(); | ||
| int getSize(); |
| Stack() : top(nullptr), size(0) {} | ||
| void push(T value); | ||
| T pop(); | ||
| T getTop(); |
|
|
||
| private: | ||
| std::stack<int> data_; | ||
| StackNode<T> *top; |
| TEST(quickSort, Simple) { | ||
| std::vector<int> data = {1, 2, 3, 4, 5}; | ||
| quickSort<int>(data); | ||
| for (auto curr : data) std::cout << curr << " "; |
Author
There was a problem hiding this comment.
Ой, да, это рудимент какой-то
| template <class T> | ||
| class BinaryTree { | ||
| public: | ||
| BinaryTree() : root(nullptr) {} |
Contributor
There was a problem hiding this comment.
тут виже только обычное дерево поиска, без балансировки, в задании дерево с балансировкой
|
|
||
| void insert(const Key& key, const Value& value); | ||
|
|
||
| bool search(const Key& key); |
Contributor
There was a problem hiding this comment.
нет функции которая возвращает value
LostPointer
requested changes
Jun 16, 2024
| if (size_ == 0) { | ||
| throw std::underflow_error("Empty stack"); | ||
| } | ||
| T returning_value = top_->data; |
Contributor
There was a problem hiding this comment.
давай так чуть соптимизируем:
T returning_value = std::move(top_->data);
Contributor
There was a problem hiding this comment.
weather_report.cpp
ну и hpp тоже переименуй
Contributor
There was a problem hiding this comment.
и в других задачах тоже
| int GetLefrChildIndex(int i) { return 2 * i + 1; } | ||
| int GetRightChildIndex(int i) { return 2 * i + 2; } | ||
|
|
||
| void heapify(int i); |
| #include <vector> | ||
|
|
||
| template <class T> | ||
| int partition(std::vector<T>& v, int low, int high) { |
| #include <vector> | ||
|
|
||
| template <class T> | ||
| int partition(std::vector<T>& v, int low, int high) { |
Contributor
There was a problem hiding this comment.
та же функция что и в предидущей задаче, давай вынесем в lib/src/utils.hpp
| BinaryTree() : root_(nullptr) {} | ||
| ~BinaryTree() { DestroyTree(root_); } | ||
|
|
||
| void insert(int value) { root_ = InsertRecursive(root_, value); } |
Contributor
There was a problem hiding this comment.
Insert
и в других местах поправь имена методов по код стайлу
| return pair.second; | ||
| } | ||
| } | ||
| throw std::logic_error("No such key in table"); |
| template <class Key, class Value> | ||
| void HashTable<Key, Value>::Rehash() { | ||
| std::vector<std::list<std::pair<Key, Value>>> new_table(table_.size() * 2); | ||
| for (const auto& list : table_) { |
Contributor
There was a problem hiding this comment.
если убрать const в обеих for то можно будет переместить элементы: new_table[index].emplace_back(std::move(pair));
LostPointer
approved these changes
Jun 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.