Skip to content

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Oct 14, 2024

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • GAQ summary is not displayed when not all runs are fully covered by QC flags
  • GAQ overview shows not covered periods

Notable changes for developers:

  • Added QC flags seeders to cover corner cases of QC/GAQ summaries displays
  • Reworked QC flag Types seeders to make them more meaningful

Changes made to the database:

  • NA

@codecov
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 89.58333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 43.83%. Comparing base (8ce02ce) to head (40bb12d).

Files with missing lines Patch % Lines
...ews/QcFlags/ActiveColumns/gaqFlagsActiveColumns.js 0.00% 4 Missing ⚠️
...Runs/RunPerDataPass/RunsPerDataPassOverviewPage.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1784      +/-   ##
==========================================
+ Coverage   43.78%   43.83%   +0.05%     
==========================================
  Files         893      893              
  Lines       15959    15981      +22     
  Branches     3005     3013       +8     
==========================================
+ Hits         6987     7006      +19     
- Misses       8972     8975       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xsalonx xsalonx marked this pull request as draft May 20, 2025 15:57
@xsalonx xsalonx closed this Jun 4, 2025
@xsalonx xsalonx deleted the xsalonx/gaq/O2B-1365/disable-gaq-if-detector-is-missing branch June 9, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants