Skip to content

[O2B-1365] Disable GAQ for not fully covered runs #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xsalonx merged 74 commits into from
Jul 22, 2025
Merged

[O2B-1365] Disable GAQ for not fully covered runs #1904

xsalonx merged 74 commits into from
Jul 22, 2025

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Jun 4, 2025 •
edited
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • GAQ summary is not displayed if not all detectors are covered by flags
  • Change display of general quality in GAQ overview
  • Add tooltip to GAQ filter reminding about expected format

Notable changes for developers:

  • Add undefinedQualityPeriodsCount property to GAQ summary

Changes made to the database:

  • Add three QC flags to seeders

xsalonx and others added 30 commits December 3, 2024 12:26
@xsalonx
use tf_timestamps
03ca36e
@xsalonx
use miliseconds
2436041
@xsalonx
remove names
06268f2
@xsalonx
use views
d6e7fcb
@xsalonx
fix tests, preserve previous functionalties
1658d1d
@xsalonx
fix
068d48c
@xsalonx
fix test
4ee19e7
@xsalonx
fix test
10be130
@xsalonx
fix test
a7a7b54
@xsalonx
fix seeders
1ee8bab
@xsalonx
Merge branch 'main' into xsalonx/gaq/O2B-1365/just-gaq-views
e152c6e
@xsalonx
use timeframe timestamps
3fb54a5
@xsalonx
Merge branch 'tmp' into xsalonx/gaq/O2B-1365/just-gaq-views
e34e920
@xsalonx
ref
db84fcc
@xsalonx
Merge branch 'main' into xsalonx/gaq/O2B-1365/just-gaq-views
5f900f8
@xsalonx
cleanup
4199b3f
@xsalonx
a
53f093a
@xsalonx
cleanup; fix
9de457c
@xsalonx
a
dc33aa6
@xsalonx
use correct field
86cb1fc
@martinboulais
Merge branch 'main' into xsalonx/gaq/O2B-1365/just-gaq-views
b56bc51
@xsalonx @martinboulais
Update lib/database/migrations/20241127123000-create-gaq-views.js
4a9ea38 
Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com>
@xsalonx
merge WIP
ccc1e9f
@xsalonx
WIP
b947915
@xsalonx
WIP
0843796
@xsalonx
use significance aggregate functions for gaq calculation
85a99d3
@xsalonx
Merge branch 'main' into xsalonx/gaq/O2B-1365/just-gaq-views
104bf3b
@xsalonx
cleanup
c7646f9
@xsalonx
count periods of undefined quality
9d82581
@xsalonx
add QC and GAQ summaries typdefs
d65a014
@xsalonx xsalonx self-assigned this Jun 4, 2025
@xsalonx xsalonx marked this pull request as ready for review June 4, 2025 22:15
@xsalonx
Copy link
Collaborator Author

xsalonx commented Jun 4, 2025

to be merged after #1808

@AliceO2Group AliceO2Group deleted a comment Jun 12, 2025
@xsalonx xsalonx merged commit b8e5f45 into main Jul 22, 2025
39 of 41 checks passed
@xsalonx xsalonx deleted the xsalonx/gaq/O2B-1365/disable-gaq branch July 22, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graduta graduta graduta approved these changes

@martinboulais martinboulais Awaiting requested review from martinboulais

Assignees

@xsalonx xsalonx

Labels

backend DB frontend

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xsalonx @graduta @martinboulais