Skip to content

Conversation

@isaachilly
Copy link
Collaborator

Using 'nocursor' when readOnly is true, ensures the blinking caret is hidden.

For example, on log entries, focussing on the log text will make a blinking caret appear, I believe this is too similar behaviour to that of editing/creating an entry and is disconcerting.

I DON'T have JIRA ticket

  • explain what this PR does
  • if it is a new feature, explain how you plan to use it
  • tests are added
  • documentation was updated or added

Notable changes for users:

  • N/A

Notable changes for developers:

  • N/A

Changes made to the database:

  • N/A

Using 'nocursor' when readOnly is true, ensures the blinking caret is hidden avoiding confusion if editing or not.
@isaachilly isaachilly self-assigned this Dec 11, 2025
@isaachilly isaachilly requested a review from graduta as a code owner December 11, 2025 15:06
@isaachilly isaachilly added frontend javascript Pull requests that update Javascript code labels Dec 11, 2025
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.61%. Comparing base (bff8c8f) to head (39bf8d4).

Files with missing lines Patch % Lines
lib/public/components/common/markdown/markdown.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2041      +/-   ##
==========================================
+ Coverage   45.47%   45.61%   +0.14%     
==========================================
  Files        1023     1023              
  Lines       17053    17054       +1     
  Branches     3092     3093       +1     
==========================================
+ Hits         7754     7780      +26     
+ Misses       9299     9274      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @isaachilly . The idea is good but by not allowing the cursor, the copy-paint functionality will not work anymore on Firefox and Chrome.
It does work on Safari, but we have to support all 3 browsers. If not easy solution is found, I would propose for the PR to be closed without merging

@isaachilly isaachilly closed this Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

4 participants