Skip to content

[O2B-1489] Update table and page height constants #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isaachilly wants to merge 2 commits into from
Closed

[O2B-1489] Update table and page height constants #2042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4eb5119
[O2B-1489] Update table and page height constants
isaachilly Dec 11, 2025
de8460e
[O2B-1489] Update tests for new page size and row count
isaachilly Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/public/views/Environments/Overview/environmentOverviewComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ import { estimateDisplayableRowsCount } from '../../../utilities/estimateDisplay
import { paginationComponent } from '../../../components/Pagination/paginationComponent.js';
import { filtersPanelPopover } from '../../../components/Filters/common/filtersPanelPopover.js';

const TABLEROW_HEIGHT = 58;
const TABLEROW_HEIGHT = 65.3;
Copy link
Member

@graduta graduta Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me the browser still displays a size of 57.6 (~58). How did you come to this new value?

// Estimate of the navbar and pagination elements height total; Needs to be updated in case of changes;
const PAGE_USED_HEIGHT = 181;
const PAGE_USED_HEIGHT = 260;
Copy link
Member

@graduta graduta Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, the browser estimate is around 181, but in my tests an 185 is better as we have paddings in rem values. A 260 is way too big.


/**
* The shows the environment table
Expand Down
8 changes: 4 additions & 4 deletions test/public/envs/overview.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ module.exports = () => {

it('Should display the correct items counter at the bottom of the page', async () => {
await expectInnerText(page, '#firstRowIndex', '1');
await expectInnerText(page, '#lastRowIndex', '9');
await expectInnerText(page, '#lastRowIndex', '7');
await expectInnerText(page, '#totalRowsCount', '9');
});

Expand Down Expand Up @@ -139,15 +139,15 @@ module.exports = () => {
await checkEnvironmentStatusColor(2, 3);
await checkEnvironmentStatusColor(3, 3);
await checkEnvironmentStatusColor(6, 3);
await checkEnvironmentStatusColor(9, 3);
await checkEnvironmentStatusColor(7, 3);
});

it('can set how many environments are available per page', async () => {
// Expect the amount selector to currently be set to 9 (because of the defined page height)
// Expect the amount selector to currently be set to 7 (because of the defined page height)
const amountSelectorId = '#amountSelector';
const amountSelectorButton = await page.waitForSelector(`${amountSelectorId} button`);
const amountSelectorButtonText = await page.evaluate((element) => element.innerText, amountSelectorButton);
expect(amountSelectorButtonText.trim().endsWith('9')).to.be.true;
expect(amountSelectorButtonText.trim().endsWith('7')).to.be.true;

// Expect the dropdown options to be visible when it is selected
await pressElement(page, `${amountSelectorId} button`);
Expand Down
Loading