Skip to content

Conversation

@isaachilly
Copy link
Collaborator

@isaachilly isaachilly commented Jan 8, 2026

Integrated the paginationComponent into QcFlagsForDataPassOverviewPage and passed the pagination model to the view.

WITHOUT tests.

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Pagination added to the qc-flags-for-data-pass page

Notable changes for developers:

  • N/A

Changes made to the database:

  • N/A

Integrated the paginationComponent into QcFlagsForDataPassOverviewPage and passed the pagination model to the view.

WITHOUT tests.
@isaachilly isaachilly self-assigned this Jan 8, 2026
@isaachilly isaachilly added frontend javascript Pull requests that update Javascript code labels Jan 8, 2026
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.43%. Comparing base (c90c344) to head (3b0a659).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2052      +/-   ##
==========================================
+ Coverage   45.42%   45.43%   +0.01%     
==========================================
  Files        1028     1028              
  Lines       17136    17134       -2     
  Branches     3120     3120              
==========================================
+ Hits         7784     7785       +1     
+ Misses       9352     9349       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@isaachilly isaachilly marked this pull request as ready for review January 8, 2026 09:57
@isaachilly isaachilly requested a review from graduta as a code owner January 8, 2026 09:57
*/
getLoadParameters() {
return {};
async getLoadParameters() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is better to simply remove the method declaration so that the parent method kicks in, rather than implementing a call directly to it.
What do you think?

Removed as only called the superclass implementation without modification.
@graduta graduta merged commit e49dbc2 into main Jan 8, 2026
23 of 24 checks passed
@graduta graduta deleted the improv/O2B-1521/RCT-Tables-Pagination branch January 8, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

3 participants