[Common,PWGHF] Complete the charmed hypernuclei search and add light-nuclei track-quality cut to the skimming task #14390
+440
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of light nuclei in the skimming task
|
O2 linter results: ❌ 25 errors, |
github-actions
bot
changed the title
zhangbiao-phy
changed the title
fgrosa
reviewed
Jan 5, 2026
Collaborator
fgrosa
left a comment
fgrosa
left a comment
There was a problem hiding this comment.
Hi @zhangbiao-phy thanks a lot for the development! I still didn't check the full PR in detail, but I have a couple of important comments to be kept in mind
zhangbiao-phy
requested review from
a team,
NicoleBastid,
alibuild,
apalasciano,
ddobrigk,
deepathoms,
fcatalan92,
fcolamar,
gluparel,
hahassan7,
iarsene,
jgrosseo,
jpxrk,
ktf,
mfaggin,
mmazzilli,
stefanopolitano and
vkucera
as code owners
vkucera
requested changes
Jan 8, 2026
Common/Core/TrackSelectorPID.h
Outdated
Comment on lines
656
to
662
| // ITS | ||
| float mPtItsMin = 0.; ///< minimum pT for TPC PID [GeV/c] | ||
| float mPtItsMax = 100.; ///< maximum pT for TPC PID [GeV/c] | ||
| float mNSigmaItsMin = -3.; ///< minimum number of TPC σ | ||
| float mNSigmaItsMax = 3.; ///< maximum number of TPC σ | ||
| float mNSigmaItsMinCondTpc = 0.; ///< minimum number of TPC σ if combined with TOF | ||
| float mNSigmaItsMaxCondTpc = 0.; ///< maximum number of TPC σ if combined with TOF |
Collaborator
Author
There was a problem hiding this comment.
Thanks for spotting this! I had it in my first version, where I added all the functions related to ITS also to the PID selector class. However, I realized that they are not commonly used in HF, so I decided not to include them. I then forgot to remove it.
vkucera
reviewed
Jan 8, 2026
|
|
||
| int8_t flag = BIT(ChannelsProtonPid::NChannelsProtonPid + 2) - 1; // all bits on (including the kaon one) | ||
| for (auto iChannel{0u}; iChannel < ChannelsProtonPid::NChannelsProtonPid + 2; ++iChannel) { | ||
| int8_t flag = BIT(ChannelsProtonPid::NChannelsProtonPid + 4) - 1; // all bits on (including the kaon one) |
Collaborator
Author
There was a problem hiding this comment.
I added two decay channels. but I fixed it now
vkucera
reviewed
Jan 8, 2026
|
|
||
| using SelectedCollisions = soa::Filtered<soa::Join<aod::Collisions, aod::HfSelCollision>>; | ||
| using TracksWithPVRefitAndDCA = soa::Join<aod::TracksWCovDcaExtra, aod::HfPvRefitTrack>; | ||
| using TracksWithPVRefitAndDCA = soa::Join<aod::FullTracks, aod::TracksWCovDcaExtra, aod::HfPvRefitTrack>; |
vkucera
reviewed
Jan 8, 2026
| #include "Common/DataModel/Centrality.h" | ||
| #include "Common/DataModel/CollisionAssociationTables.h" | ||
| #include "Common/DataModel/EventSelection.h" | ||
| #include "Common/DataModel/PIDResponseITS.h" |
Collaborator
Author
There was a problem hiding this comment.
which need it for ITS nsigma PID in:
auto tracksWithItsPid = soa::Attach<TTracks, aod::pidits::ITSNSigmaDe, aod::pidits::ITSNSigmaTr, aod::pidits::ITSNSigmaHe>(tracks);
vkucera
reviewed
Jan 8, 2026
| const std::vector<double> ptBinsMl{0., 1.e10}; | ||
| const std::vector<int> cutDirMl{o2::cuts_ml::CutDirection::CutGreater, o2::cuts_ml::CutDirection::CutSmaller, o2::cuts_ml::CutDirection::CutSmaller}; | ||
| const std::array<LabeledArray<double>, kN3ProngDecays - 1> thresholdMlScore3Prongs{config.thresholdMlScoreDplusToPiKPi, config.thresholdMlScoreLcToPiKP, config.thresholdMlScoreDsToPiKK, config.thresholdMlScoreXicToPiKP}; | ||
| const std::array<LabeledArray<double>, kN3ProngDecays - 3> thresholdMlScore3Prongs{config.thresholdMlScoreDplusToPiKPi, config.thresholdMlScoreLcToPiKP, config.thresholdMlScoreDsToPiKK, config.thresholdMlScoreXicToPiKP}; |
vkucera
reviewed
Jan 8, 2026
|
|
||
| // initialise 3-prong ML responses | ||
| for (int iDecay3P{0}; iDecay3P < kN3ProngDecays - 1; ++iDecay3P) { | ||
| for (int iDecay3P{0}; iDecay3P < kN3ProngDecays - 3; ++iDecay3P) { |
zhangbiao-phy
added a commit
to zhangbiao-phy/O2Physics
that referenced
this pull request
Jan 8, 2026
[PWGHF] Please consider the following formatting changes to AliceO2Group#14390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag @fgrosa for the informations