Skip to content

[PWGJE] fix of broken bc retrieval in derivedDataProducer #14399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nzardosh merged 1 commit into from
Jan 6, 2026
+1 −1
Merged

[PWGJE] fix of broken bc retrieval in derivedDataProducer #14399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PWGJE/TableProducer/derivedDataProducer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGJE/TableProducer/derivedDataProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Specify task name only when it cannot be derived from the struct name. Only append to the default name.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand Down Expand Up @@ -253,7 +253,7 @@

void processCollisions(soa::Join<aod::Collisions, aod::EvSels, aod::FV0Mults, aod::FT0Mults, aod::CentFV0As, aod::CentFT0As, aod::CentFT0Cs, aod::CentFT0Ms, aod::CentFT0CVariant1s>::iterator const& collision, soa::Join<aod::BCs, aod::BcSels, aod::Timestamps> const& bcs, aod::FT0s const&, aod::FV0As const&, aod::FDDs const&)
{
auto bc = collision.bc_as<soa::Join<aod::BCs, aod::Timestamps>>();
auto bc = collision.bc_as<soa::Join<aod::BCs, aod::BcSels, aod::Timestamps>>();
if (config.includeHadronicRate) {
if (runNumber != bc.runNumber()) {
runNumber = bc.runNumber();
Expand Down Expand Up @@ -509,14 +509,14 @@
std::vector<int32_t> mothersId;
if (particle.has_mothers()) {
auto mothersIdTemps = particle.mothersIds();
for (auto mothersIdTemp : mothersIdTemps) {

Check failure on line 512 in PWGJE/TableProducer/derivedDataProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
mothersId.push_back(mothersIdTemp);
}
}
int daughtersId[2] = {-1, -1};
if (particle.has_daughters()) {
auto i = 0;
for (auto daughterId : particle.daughtersIds()) {

Check failure on line 519 in PWGJE/TableProducer/derivedDataProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (i > 1) {
break;
}
Expand All @@ -532,7 +532,7 @@
void processClusters(aod::Collision const&, aod::EMCALClusters const& clusters, aod::EMCALClusterCells const& cells, aod::Calos const&, aod::EMCALMatchedTracks const& matchedTracks, soa::Join<aod::Tracks, aod::TracksExtra> const&)
{

for (auto cluster : clusters) {

Check failure on line 535 in PWGJE/TableProducer/derivedDataProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.

auto const clusterCells = cells.sliceBy(preslices.perClusterCells, cluster.globalIndex());

Expand Down Expand Up @@ -572,7 +572,7 @@
void processMcClusterLabels(aod::EMCALMCCluster const& cluster)
{
std::vector<int32_t> particleIds;
for (auto particleId : cluster.mcParticleIds()) {

Check failure on line 575 in PWGJE/TableProducer/derivedDataProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
particleIds.push_back(particleId);
}
std::vector<float> amplitudeA;
Expand Down Expand Up @@ -867,14 +867,14 @@
std::vector<int32_t> mothersId;
if (particle.has_mothers()) {
auto mothersIdTemps = particle.mothersIds();
for (auto mothersIdTemp : mothersIdTemps) {

Check failure on line 870 in PWGJE/TableProducer/derivedDataProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
mothersId.push_back(mothersIdTemp);
}
}
int daughtersId[2] = {-1, -1};
if (particle.has_daughters()) {
auto i = 0;
for (auto daughterId : particle.daughtersIds()) {

Check failure on line 877 in PWGJE/TableProducer/derivedDataProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (i > 1) {
break;
}
Expand Down Expand Up @@ -921,14 +921,14 @@
std::vector<int32_t> mothersId;
if (particle.has_mothers()) {
auto mothersIdTemps = particle.mothersIds();
for (auto mothersIdTemp : mothersIdTemps) {

Check failure on line 924 in PWGJE/TableProducer/derivedDataProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
mothersId.push_back(mothersIdTemp);
}
}
int daughtersId[2] = {-1, -1};
if (particle.has_daughters()) {
auto i = 0;
for (auto daughterId : particle.daughtersIds()) {

Check failure on line 931 in PWGJE/TableProducer/derivedDataProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (i > 1) {
break;
}
Expand All @@ -949,5 +949,5 @@
WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
{
return WorkflowSpec{
adaptAnalysisTask<JetDerivedDataProducerTask>(cfgc, TaskName{"jet-deriveddata-producer"})};

Check failure on line 952 in PWGJE/TableProducer/derivedDataProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Specified task name jet-deriveddata-producer produces device name jet-deriveddata-producer which does not match the device name jet-derived-data-producer-task from the struct name JetDerivedDataProducerTask. (Matching struct name JetDeriveddataProducer)
}
Loading