Skip to content

[PWGHF] Introducing a reduced workflow for D+ pairs #14443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
VDiBella wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[PWGHF] Introducing a reduced workflow for D+ pairs #14443

VDiBella wants to merge 1 commit into from
+698 −0

Conversation

@VDiBella
Copy link
Contributor

@VDiBella VDiBella commented Jan 9, 2026

The content of this pull request has been discussed at the HFC meeting on the 05/12/2025.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 3 disabled

@github-actions github-actions bot changed the title Introducing a reduced workflow for D+ pairs [PWGHF] Introducing a reduced workflow for D+ pairs Jan 9, 2026
@alibuild alibuild mentioned this pull request Jan 9, 2026
Closed
@VDiBella VDiBella force-pushed the dev branch 5 times, most recently from 5cc4834 to c54d051 Compare January 9, 2026 13:29
@alibuild alibuild mentioned this pull request Jan 9, 2026
Closed
@VDiBella VDiBella force-pushed the dev branch 3 times, most recently from 686509a to 6243c30 Compare January 9, 2026 13:44
@alibuild
Copy link
Collaborator

alibuild commented Jan 9, 2026

Error while checking build/O2Physics/o2 for 6243c30 at 2026-01-09 19:39:

[2437/2853] Building CXX object PWGEM/PhotonMeson/Core/CMakeFiles/O2Physicslib-PWGEMPhotonMesonCore.dir/G__O2PhysicsPWGEMPhotonMesonCore.cxx.o
[2438/2853] Building CXX object PWGEM/Dilepton/Tasks/CMakeFiles/O2Physicsexe-analysis-em-dielectron.dir/dielectron.cxx.o
[2439/2853] Linking CXX shared library stage/lib64/libO2PhysicsPWGEMPhotonMesonCore.so
[2440/2853] Linking CXX executable stage/bin/o2-analysistutorial-full-track-iteration
[2441/2853] Linking CXX executable stage/bin/o2-analysis-em-dielectron
[2442/2853] Building CXX object PWGDQ/Tasks/CMakeFiles/O2Physicsexe-analysis-dq-flow.dir/dqFlow.cxx.o
[2443/2853] Building CXX object PWGDQ/Tasks/CMakeFiles/O2Physicsexe-analysis-dq-qa-matching.dir/qaMatching.cxx.o
[2444/2853] Linking CXX executable stage/bin/o2-analysis-dq-flow
[2445/2853] Linking CXX executable stage/bin/o2-analysis-dq-qa-matching
[2446/2853] Building CXX object PWGEM/PhotonMeson/Tasks/CMakeFiles/O2Physicsexe-analysis-em-pcm-qc.dir/pcmQC.cxx.o
[2447/2853] Building CXX object PWGDQ/TableProducer/CMakeFiles/O2Physicsexe-analysis-dq-generated-quarkonia-mc.dir/generatedQuarkoniaMC.cxx.o
[2448/2853] Linking CXX executable stage/bin/o2-analysis-em-pcm-qc
[2449/2853] Building CXX object PWGEM/PhotonMeson/Tasks/CMakeFiles/O2Physicsexe-analysis-em-emcal-qc.dir/emcalQC.cxx.o
[2450/2853] Building CXX object PWGDQ/TableProducer/CMakeFiles/O2Physicsexe-analysis-dq-table-maker-muon-mch-trk-eff.dir/tableMakerMuonMchTrkEfficiency.cxx.o
[2451/2853] Linking CXX executable stage/bin/o2-analysis-dq-generated-quarkonia-mc
[2452/2853] Linking CXX executable stage/bin/o2-analysis-em-emcal-qc
[2453/2853] Linking CXX executable stage/bin/o2-analysis-dq-table-maker-muon-mch-trk-eff
[2454/2853] Building CXX object PWGEM/PhotonMeson/Tasks/CMakeFiles/O2Physicsexe-analysis-em-dalitz-ee-qc.dir/dalitzEEQC.cxx.o
[2455/2853] Building CXX object PWGEM/PhotonMeson/Tasks/CMakeFiles/O2Physicsexe-analysis-em-phos-qc.dir/phosQC.cxx.o
[2456/2853] Building CXX object PWGEM/Dilepton/Tasks/CMakeFiles/O2Physicsexe-analysis-em-prefilter-dielectron.dir/prefilterDielectron.cxx.o
[2457/2853] Linking CXX executable stage/bin/o2-analysis-em-dalitz-ee-qc
[2458/2853] Linking CXX executable stage/bin/o2-analysis-em-phos-qc
[2459/2853] Linking CXX executable stage/bin/o2-analysis-em-prefilter-dielectron
[2460/2853] Building CXX object PWGEM/PhotonMeson/Tasks/CMakeFiles/O2Physicsexe-analysis-em-pcm-qc-mc.dir/pcmQCMC.cxx.o
[2461/2853] Building CXX object PWGEM/PhotonMeson/Tasks/CMakeFiles/O2Physicsexe-analysis-em-dalitz-ee-qc-mc.dir/dalitzEEQCMC.cxx.o
[2462/2853] Linking CXX executable stage/bin/o2-analysis-em-pcm-qc-mc
[2463/2853] Linking CXX executable stage/bin/o2-analysis-em-dalitz-ee-qc-mc
[2464/2853] Building CXX object PWGEM/PhotonMeson/Tasks/CMakeFiles/O2Physicsexe-analysis-em-single-photon.dir/SinglePhoton.cxx.o
[2465/2853] Building CXX object PWGEM/PhotonMeson/Tasks/CMakeFiles/O2Physicsexe-analysis-em-omega-meson-emc.dir/OmegaMesonEMC.cxx.o
[2466/2853] Linking CXX executable stage/bin/o2-analysis-em-single-photon
[2467/2853] Building CXX object PWGEM/Dilepton/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-dimuon-producer.dir/dimuonProducer.cxx.o
[2468/2853] Linking CXX executable stage/bin/o2-analysis-em-omega-meson-emc
[2469/2853] Building CXX object PWGDQ/Tasks/CMakeFiles/O2Physicsexe-analysis-dq-efficiency.dir/dqEfficiency.cxx.o
[2470/2853] Linking CXX executable stage/bin/o2-analysis-em-dimuon-producer
[2471/2853] Building CXX object PWGEM/PhotonMeson/Tasks/CMakeFiles/O2Physicsexe-analysis-em-heavy-neutral-meson.dir/HeavyNeutralMeson.cxx.o
[2472/2853] Linking CXX executable stage/bin/o2-analysis-dq-efficiency
[2473/2853] Linking CXX executable stage/bin/o2-analysis-em-heavy-neutral-meson
[2474/2853] Building CXX object PWGDQ/TableProducer/CMakeFiles/O2Physicsexe-analysis-dq-table-maker-jpsi-hf.dir/tableMakerJpsiHf.cxx.o
[2475/2853] Building CXX object PWGDQ/Tasks/CMakeFiles/O2Physicsexe-analysis-dq-efficiency-with-assoc-direct.dir/dqEfficiency_withAssoc_direct.cxx.o
[2476/2853] Linking CXX executable stage/bin/o2-analysis-dq-table-maker-jpsi-hf
[2477/2853] Building CXX object PWGEM/Dilepton/TableProducer/CMakeFiles/O2Physicsexe-analysis-em-dielectron-producer.dir/dielectronProducer.cxx.o
[2478/2853] Building CXX object PWGEM/PhotonMeson/Tasks/CMakeFiles/O2Physicsexe-analysis-em-single-photon-mc.dir/SinglePhotonMC.cxx.o
[2479/2853] Linking CXX executable stage/bin/o2-analysis-em-dielectron-producer
[2480/2853] Linking CXX executable stage/bin/o2-analysis-dq-efficiency-with-assoc-direct
[2481/2853] Linking CXX executable stage/bin/o2-analysis-em-single-photon-mc
[2482/2853] Building CXX object PWGDQ/Tasks/CMakeFiles/O2Physicsexe-analysis-dq-efficiency-with-assoc.dir/dqEfficiency_withAssoc.cxx.o
[2483/2853] Building CXX object PWGEM/Dilepton/Tasks/CMakeFiles/O2Physicsexe-analysis-em-dimuon-hadron-mpc.dir/dimuonHadronMPC.cxx.o
[2484/2853] Linking CXX executable stage/bin/o2-analysis-dq-efficiency-with-assoc
[2485/2853] Linking CXX executable stage/bin/o2-analysis-em-dimuon-hadron-mpc
[2486/2853] Building CXX object PWGEM/PhotonMeson/Tasks/CMakeFiles/O2Physicsexe-analysis-em-pi0eta-to-gammagamma-mc-emcemc.dir/Pi0EtaToGammaGammaMCEMCEMC.cxx.o

Full log here.

@vkucera
Copy link
Collaborator

vkucera commented Jan 9, 2026

Fix the warning.

@VDiBella
Copy link
Contributor Author

VDiBella commented Jan 12, 2026

Fix the warning.

Hello, I can't find the warning you're talking about. Can you elaborate please ?

Thanks a lot.

@vkucera
Copy link
Collaborator

vkucera commented Jan 12, 2026

Fix the warning.

Hello, I can't find the warning you're talking about. Can you elaborate please ?

Thanks a lot.

PWGHF/HFC/Tasks/taskCorrelationDplusDplusReduced.cxx:18: warning: Documentation for \file is missing, incorrect or misplaced. [doc/file]

vkucera
vkucera reviewed Jan 12, 2026
View reviewed changes
PWGHF/HFC/Tasks/taskCorrelationDplusDplusReduced.cxx
Comment on lines +20 to +23
#include "PWGHF/Core/DecayChannels.h"
#include "PWGHF/HFC/DataModel/ReducedDMesonPairsTables.h"

#include "Framework/runDataProcessing.h"
Copy link
Collaborator

@vkucera vkucera Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt that those are all used headers.
Fix the format.

Copy link
Contributor Author

@VDiBella VDiBella Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, after a test again if any of the three headers are missing the code wont compile.

Copy link
Collaborator

@vkucera vkucera Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My point was the other way around. I suspect that you don't include all used headers.

@vkucera
Copy link
Collaborator

vkucera commented Jan 12, 2026

Don't force push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

datamodel pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VDiBella @alibuild @vkucera