Skip to content

[OGUI-1557] Added Try Catch for kafkaclient #2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graduta merged 2 commits into from
Nov 21, 2024
Merged

[OGUI-1557] Added Try Catch for kafkaclient #2668

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbf9153
Added Try Catch for kafkaclient
Nov 20, 2024
68d68d0
Merge branch 'dev' into bug/pepijndik/OGUI-1557/Possibleo2-cogcrashwh…
Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions Control/lib/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,15 +117,20 @@

let aliEcsSynchronizer = undefined;
if (config.kafka && config.kafka?.enable) {
const kafkaClient = new Kafka({
clientId: 'control-gui',
brokers: config.kafka.brokers,
retry: { retries: 3 },
logLevel: logLevel.NOTHING,
});

aliEcsSynchronizer = new AliEcsSynchronizer(kafkaClient, cacheService);
aliEcsSynchronizer.start();
try {
const kafkaClient = new Kafka({

Check warning on line 121 in Control/lib/api.js

View check run for this annotation

Codecov / codecov/patch

Control/lib/api.js#L120-L121 

Added lines #L120 - L121 were not covered by tests
clientId: 'control-gui',
brokers: config.kafka.brokers,
retry: { retries: 3 },
logLevel: logLevel.NOTHING,
});
aliEcsSynchronizer = new AliEcsSynchronizer(kafkaClient, cacheService);
aliEcsSynchronizer.start();

Check warning on line 128 in Control/lib/api.js

View check run for this annotation

Codecov / codecov/patch

Control/lib/api.js#L127-L128 

Added lines #L127 - L128 were not covered by tests

} catch (error) {
logger.errorMessage(`Kafka initialization failed: ${error.message}`);

Check warning on line 131 in Control/lib/api.js

View check run for this annotation

Codecov / codecov/patch

Control/lib/api.js#L131 

Added line #L131 was not covered by tests
}

}

const statusService = new StatusService(
Expand Down