Skip to content

Conversation

@pepijndik
Copy link

@pepijndik pepijndik commented Dec 2, 2024

Middleware for checking if a user has a matching detector role

  • Added User belongsToDetector

  • DetectorOwnership middleware

  • DetectorOwnershipMiddleware tests

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

@graduta graduta changed the title [OGUI-1580] addmiddlewarefordetectormatchinguserrole [OGUI-1580] add middleware for detector matching user role Dec 2, 2024
@pepijndik pepijndik requested a review from graduta December 3, 2024 08:15
@graduta graduta removed the tests label Dec 3, 2024
pdik added 3 commits December 3, 2024 19:25
Check isRoleSufficient
Detector ownership can have higher role than it's detector. Test this behavior
@pepijndik pepijndik requested a review from graduta December 3, 2024 19:04
pdik and others added 5 commits December 9, 2024 09:14
in URL detectorid is uppercase while in accesslist not so convert them to lower
…OGUI-1580/Addmiddlewarefordetectormatchinguserrole
@graduta graduta merged commit 9be04f5 into dev Jun 2, 2025
11 of 13 checks passed
@graduta graduta deleted the feature/pep/OGUI-1580/Addmiddlewarefordetectormatchinguserrole branch June 2, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants