[OGUI-1729] Implement restrictions endpoint #2952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Deaponn
commented
Jun 23, 2025
Deaponn
commented
- branch and/or PR name(s) includes JIRA ID
- issue "Status" is set to "In review"
- PR labels are selected
…ionController and create QCConfiguration.service
…s for qcConfigurationController and qcConfigurationService
…ionController and create QCConfiguration.service
…s for qcConfigurationController and qcConfigurationService
Deaponn
changed the base branch from
dev
to
feature/CNF/OGUI-1698/implement-configuration-endpoint
Deaponn
changed the base branch from
feature/CNF/OGUI-1698/implement-configuration-endpoint
to
dev
Deaponn
changed the base branch from
dev
to
feature/CNF/OGUI-1698/implement-configuration-endpoint
… into feature/CNF/OGUI-1729/restrictions-endpoint
Base automatically changed from
feature/CNF/OGUI-1698/implement-configuration-endpoint
to
dev
August 28, 2025 10:28
minor enhancements
sKrzysieK
reviewed
Nov 12, 2025
Collaborator
sKrzysieK
left a comment
sKrzysieK
left a comment
There was a problem hiding this comment.
Generally LGTM but there are a few things I'd like to be clarified
graduta
requested changes
Nov 13, 2025
Member
graduta
left a comment
graduta
left a comment
There was a problem hiding this comment.
For Control project, we limit ourselves to using ' single quotes for strings, imports, etc. Please update so across your PR
Control/test/lib/adapters/mocha-consul-configuration.adapter.test.js
Outdated
Show resolved
Hide resolved
Control/test/lib/adapters/mocha-consul-configuration.adapter.test.js
Outdated
Show resolved
Hide resolved
graduta
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.