On the Character sheet, "Import"ing charms should search compendiums#56
Open
ev-ev-ev wants to merge 1 commit intoAliharu:mainfrom
Open
On the Character sheet, "Import"ing charms should search compendiums#56ev-ev-ev wants to merge 1 commit intoAliharu:mainfrom
ev-ev-ev wants to merge 1 commit intoAliharu:mainfrom
Conversation
Default disabled, when enabled, importing charms from the character sheet will search the compendiums as well as only the imported items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For my own games, I've created a series of compendiums with a lot of charms.
Today, I import from the compendiums (taking care to keep the document IDs), and run a script to grant observer rights to all players.
This takes some time, and is error prone.
If this PR is merged, the character sheet charm importer will scan the compendiums when choosing which charms to display.
One reason not to merge this is the first-time load performance cost. With 3850 charms in compendiums, it takes about 3 seconds with my PC and my server, but it could be worse on smaller servers. I did include a performance optimization to reduce this time on subsequent uses.