This repository was archived by the owner on Feb 20, 2025. It is now read-only.
refact: make custom config also defined within env blocks.#264
Open
Colstuwjx wants to merge 1 commit intoAliyunContainerService:masterfrom
Open
refact: make custom config also defined within env blocks.#264Colstuwjx wants to merge 1 commit intoAliyunContainerService:masterfrom
Colstuwjx wants to merge 1 commit intoAliyunContainerService:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
==========================================
+ Coverage 21.46% 22.11% +0.65%
==========================================
Files 7 7
Lines 778 755 -23
==========================================
Hits 167 167
+ Misses 581 559 -22
+ Partials 30 29 -1
Continue to review full report at Codecov.
|
Author
|
@chenquanzhao , I'm sorry, I have tried the #244 way, and this PR is my answer to customize the log-collect config for each container. Just as the PR description said, feel free to merge or close this PR. |
8e02473 to
1e1938d
Compare
|
@jzwlqx Hope this PR cat be accept. I tested it on my cluster, it's working fine. And I also used #244 way to config my yaml file, seems not working. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR is an alternative for #244 , we have been tried to use the #244 PR proposed configuration way, however, it didn't work well in my cluster. We don't want to maintain another configmap to map to the custom_configs env, and it also hard to set such multiple-line content with a single env kv pair.
As a result, We try to propose another solution for solving such customization for filebeat ( even the other log-collector ), just take the same way that
Tagsdo and it seems also match our log-pilot design.Feel free to merge this PR or close it.
Thanks.