Skip to content

[pull] trunk from cli:trunk #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 7 commits into from
Jan 19, 2026
Merged

[pull] trunk from cli:trunk #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0f32f2a
refactor(run download): extract zip extraction func into a separate p…
babakks Jan 19, 2026
3988065
feat: add `copilot` command
babakks Jan 19, 2026
08a4413
chore(root): register `copilot` command
babakks Jan 19, 2026
10b4a1f
fix(root): avoid command name collision when registering extensions
babakks Jan 19, 2026
bc5a44a
fix(copilot): replace `windows` with `win32` to match asset names
babakks Jan 19, 2026
d187bef
Fix OS name in test archive filename to 'win32'
BagToad Jan 19, 2026
2728635
Merge pull request #12444 from devm33/ghcopilot
BagToad Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added internal/zip/fixtures/myproject.zip
View file
Open in desktop
Binary file not shown.
8 changes: 6 additions & 2 deletions pkg/cmd/run/download/zip.go → internal/zip/zip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package download
package zip

import (
"archive/zip"
Expand All @@ -17,7 +17,11 @@ const (
execMode os.FileMode = 0755
)

func extractZip(zr *zip.Reader, destDir safepaths.Absolute) error {
// ExtractZip extracts the contents of a zip archive to destDir.
// Files that would result in path traversal are silently skipped.
// Files that would produce any other error cause the extraction to be aborted,
// and the error is returned.
func ExtractZip(zr *zip.Reader, destDir safepaths.Absolute) error {
for _, zf := range zr.File {
fpath, err := destDir.Join(zf.Name)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions pkg/cmd/run/download/zip_test.go → internal/zip/zip_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package download
package zip

import (
"archive/zip"
Expand All @@ -19,7 +19,7 @@ func Test_extractZip(t *testing.T) {
require.NoError(t, err)
defer zipFile.Close()

err = extractZip(&zipFile.Reader, extractPath)
err = ExtractZip(&zipFile.Reader, extractPath)
require.NoError(t, err)

_, err = os.Stat(filepath.Join(extractPath.String(), "src", "main.go"))
Expand Down
Loading