Skip to content

[pull] trunk from cli:trunk #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 3 commits into from
Jan 22, 2026
Merged

[pull] trunk from cli:trunk #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd0177b
Fix fmt.Errorf format argument in ParseFullReference
mikelolasagasti Jan 21, 2026
0d8a697
fix(pr/shared): improve `ParseFullReference` error message
babakks Jan 21, 2026
3220ab5
Merge pull request #12516 from mikelolasagasti/pr-shared-error-atoi
babakks Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cmd/pr/shared/finder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ func ParseFullReference(s string) (ghrepo.Interface, int, error) {

number, err := strconv.Atoi(m[3])
if err != nil {
return nil, 0, fmt.Errorf("invalid reference: %q", number)
return nil, 0, fmt.Errorf("invalid reference: %q; %w", s, err)
}

owner := m[1]
Expand Down
5 changes: 5 additions & 0 deletions pkg/cmd/pr/shared/finder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,11 @@ func TestParseFullReference(t *testing.T) {
arg: "OWNER/#123",
wantErr: `invalid reference: "OWNER/#123"`,
},
{
name: "invalid full form, too large number",
arg: "OWNER/REPO#9999999999999999999",
wantErr: `invalid reference: "OWNER/REPO#9999999999999999999"; strconv.Atoi: parsing "9999999999999999999": value out of range`,
},
}

for _, tt := range tests {
Expand Down