feat: Add user profile picture upload functionality#676
Open
aj47 wants to merge 1 commit intoAllYourBot:mainfrom
Open
feat: Add user profile picture upload functionality#676aj47 wants to merge 1 commit intoAllYourBot:mainfrom
aj47 wants to merge 1 commit intoAllYourBot:mainfrom
Conversation
- Add profile picture attachment to User model with Active Storage - Implement image variants (thumbnail: 50x50, small: 100x100, medium: 200x200) - Add comprehensive validations for file type (JPEG, PNG, GIF, WebP) and size (max 5MB) - Update user avatar partial to display profile pictures with graceful fallback to initials - Add profile picture upload form to settings with preview functionality - Implement JavaScript controller for client-side validation and preview - Add helper methods for profile picture URL generation and image tags - Include comprehensive test coverage for models, controllers, and helpers - Support profile picture removal with confirmation - Store images directly in PostgreSQL database using existing Active Storage setup Technical details: - Uses existing Active Storage with PostgreSQL service (no external infrastructure) - Automatic image processing with variants for different display sizes - Client and server-side validation for security and UX - Maintains existing avatar display locations (navigation, messages) - Production-ready with proper error handling and fallbacks
Collaborator
|
Looks cool. I'll review and test this very soon. |
mattlindsey
requested changes
Sep 7, 2025
Collaborator
mattlindsey
left a comment
mattlindsey
left a comment
There was a problem hiding this comment.
Looks like the 'Remove' image button need to be implemented with a test.
ceicke
reviewed
Nov 17, 2025
|
|
||
| # Windows does not include zoneinfo files, so bundle the tzinfo-data gem | ||
| gem "tzinfo-data", platforms: %i[windows jruby] | ||
| gem "tzinfo-data", platforms: %i[mswin mswin64 mingw x64_mingw jruby] |
Collaborator
There was a problem hiding this comment.
Nitpicking here: I would prefer these kind of infrastructure changes at least into a separate commit within this PR.
| group :development, :test do | ||
| # See https://guides.rubyonrails.org/debugging_rails_applications.html#debugging-with-the-debug-gem | ||
| gem "debug", platforms: %i[mri windows] | ||
| gem "debug", platforms: %i[mri mswin mswin64 mingw x64_mingw] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🖼️ User Profile Picture Upload Feature
This PR implements comprehensive user profile picture upload functionality with database storage and no external infrastructure requirements.
✨ Features
🔧 Technical Implementation
Backend Changes
has_one_attached :profile_picturewith custom validationSettings::PeopleControllerto handle profile picture uploadsFrontend Changes
Database
🧪 Testing
📍 Integration Points
Profile pictures automatically appear in:
_user_avatarpartial🔒 Security & Validation
🚀 Production Ready
📝 Files Changed
app/models/user.rb- Profile picture attachment and validationapp/controllers/settings/people_controller.rb- Upload handlingapp/views/settings/people/_form.html.erb- Upload form UIapp/views/layouts/_user_avatar.erb- Avatar display logicapp/javascript/stimulus/profile_picture_upload_controller.js- Client-side functionalityapp/helpers/application_helper.rb- Helper methods🎯 Testing Instructions
This implementation follows Rails best practices and is ready for production use.
Pull Request opened by Augment Code with guidance from the PR author