Merged
Conversation
interim17
commented
Jan 21, 2026
| - run: npm run lint --if-present | ||
| test: | ||
| - run: npm run lint | ||
| format: |
Contributor
Author
There was a problem hiding this comment.
This was called test but was actually format
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Vitest as a testing framework to the repository and creates initial test coverage for utility functions. It also improves CI workflow consistency by removing --if-present flags and reorganizing job definitions.
Changes:
- Added Vitest dependency and configured test script to run tests
- Created comprehensive unit tests for utility functions in
src/utils/index.test.ts - Updated CI workflow to include a dedicated test job and removed
--if-presentflags from lint and format check steps
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/utils/index.test.ts | New test file covering utility functions with various test cases |
| src/components/CellLineInfoCard/CellLineInfoCardBase.tsx | Alphabetized CSS module imports |
| src/component-queries/NavBar.tsx | Alphabetized CSS module imports |
| package.json | Added vitest dependency and configured test script |
| .github/workflows/ci.yml | Added test job, removed --if-present flags, and renamed jobs for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rugeli
reviewed
Jan 21, 2026
| - run: npm run lint --if-present | ||
| test: | ||
| - run: npm run lint | ||
| format: |
meganrm
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #415
These tests aren't exactly critical, but this PR installs vitest and adds a test block to our
ci.ymlI also pulled out the
--if-presentflags in theci.ymlthat maybe we should discuss, seems like those flags are not necessary if our scripts are running properly, and could lead to silent failures? If the scripts are failing we would want to know?