BREAKING CHANGE: bump to aind-data-schema v2 in helpers#176
Open
BREAKING CHANGE: bump to aind-data-schema v2 in helpers#176
Conversation
3 tasks
Collaborator
|
This PR would introduce a breaking change due to upgrading aind-data-schema v1 to v2. @dbirman could you mark the PR with BREAKING CHANGE? Also, there are a few other features for aind-data-schema v1 that should be released first (#93 and #181, #106, #107) before we do a major release. Edits:
|
Member
Author
|
Marking as blocked until we get the lambda, other changes requested by Helen are in the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the aind-data-schema version to v2 and fixes the helper QC functions to run off of V2 QC data.
Note this PR bumps to Python 3.10 minimum because of the aind-data-schema requirement.